Repository navigation
Adding Continuous Acquisition Chart Multiple Samples example in NI-DMM #2220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NI-velmurugan
wants to merge
13
commits into
ni:master
Choose a base branch
from
NI-velmurugan:users/velmurugan/add-nidmm-cont-acq-chart-multiple-samples
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1ee80b2
feat: add nidmm cont acq chart multiple samples example
NI-velmurugan 3d7669b
simplify plotting
divakar-selvam07 20c6c25
implement minor improvements and include matplotlib in tox env
divakar-selvam07 4d53b59
Adding fix for testing the examples with matplotlib
NI-velmurugan be80a33
Reverting change on example, and fixing the pipeline error
NI-velmurugan 0226df1
Changes the plotting logic
NI-velmurugan 6edc712
Updating the cancel logic to match the existing examples
NI-velmurugan 394cfec
Fixing flake8 failure
NI-velmurugan 9562e54
Simlifying the graph logic to helper functions
NI-velmurugan 91f7a3d
Trigger CI build
divakar-selvam07 82b855c
Trigger CI build
divakar-selvam07 e744de4
Trigger CI build
divakar-selvam07 858edf5
Merge branch 'master' into users/velmurugan/add-nidmm-cont-acq-chart-…
NI-velmurugan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109 changes: 109 additions & 0 deletions
109
src/nidmm/examples/nidmm_cont_acq_chart_multiple_samples.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| #!/usr/bin/python | ||
|
|
||
| import argparse | ||
| import collections | ||
| import nidmm | ||
| import pytest | ||
| import sys | ||
|
|
||
|
|
||
| # Number of most recent measurements kept on the chart | ||
| CHART_HISTORY_SIZE = 250 | ||
|
|
||
|
|
||
| def _create_chart(plt): | ||
| figure, axes = plt.subplots() | ||
| (line,) = axes.plot([]) | ||
| axes.set_title('Measurements') | ||
| axes.set_xlabel('Samples') | ||
| axes.set_ylabel('Measured value') | ||
| axes.grid(True) | ||
| return figure, axes, line | ||
|
|
||
|
|
||
| def _update_chart(plt, axes, line, measurements, new_samples, samples_fetched): | ||
| measurements.extend(new_samples) | ||
| samples_fetched += len(new_samples) | ||
| # The x-axis keeps absolute sample numbers, so it starts after the samples dropped from the history | ||
| first_sample = samples_fetched - len(measurements) | ||
| line.set_data(range(first_sample, samples_fetched), measurements) | ||
| axes.relim() | ||
| axes.autoscale_view() | ||
| plt.pause(0.001) | ||
| return samples_fetched | ||
|
|
||
|
|
||
| def example(resource_name, options, function, measurement_range, digits, samples_to_fetch, total_samples): | ||
| # Imported lazily because matplotlib is unavailable on some platforms (e.g. 32-bit Python) | ||
| import matplotlib.pyplot as plt | ||
|
|
||
| with nidmm.Session(resource_name=resource_name, options=options) as session: | ||
| session.configure_measurement_digits(measurement_function=nidmm.Function[function], range=measurement_range, resolution_digits=digits) | ||
| # A sample_count of 0 configures a continuous acquisition | ||
| session.configure_multi_point(trigger_count=1, sample_count=0) | ||
|
|
||
| # Create an empty chart; the line is filled in as samples arrive | ||
| figure, axes, line = _create_chart(plt) | ||
| # Only the most recent CHART_HISTORY_SIZE measurements are kept | ||
| measurements = collections.deque(maxlen=CHART_HISTORY_SIZE) | ||
|
|
||
| try: | ||
| with session.initiate(): | ||
| samples_fetched = 0 | ||
|
|
||
| # A total_samples of None runs until the chart window is closed or Ctrl+C is pressed | ||
| while plt.fignum_exists(figure.number) and ( | ||
| total_samples is None or samples_fetched < total_samples | ||
| ): | ||
| # The last fetch only takes the samples still needed to reach total_samples | ||
| samples_in_this_fetch = samples_to_fetch | ||
| if total_samples is not None: | ||
| samples_in_this_fetch = min(samples_to_fetch, total_samples - samples_fetched) | ||
|
|
||
| new_samples = session.fetch_multi_point(array_size=samples_in_this_fetch) | ||
|
|
||
| # Add the new samples to the chart and get the updated total sample count | ||
| samples_fetched = _update_chart(plt, axes, line, measurements, new_samples, samples_fetched) | ||
|
|
||
| # The acquisition has stopped; keep the final chart on screen until its window is closed | ||
| if total_samples is not None and plt.fignum_exists(figure.number): | ||
| plt.show() | ||
| except KeyboardInterrupt: | ||
| pass | ||
| finally: | ||
| plt.close(figure) | ||
|
|
||
|
|
||
| def _main(argsv): | ||
| parser = argparse.ArgumentParser(description='Continuously acquires measurements and displays them on a chart using the NI-DMM API.', formatter_class=argparse.ArgumentDefaultsHelpFormatter) | ||
| parser.add_argument('-n', '--resource-name', default='PXI1Slot2', help='Contains the resource_name of the device to initialize.') | ||
| parser.add_argument('-f', '--function', default='DC_VOLTS', choices=nidmm.Function.__members__.keys(), type=str.upper, help='Specifies the measurement_function used to acquire the measurement.') | ||
| parser.add_argument('-r', '--range', default=10, type=float, help='Specifies the range for the function specified in the Measurement_Function parameter.') | ||
| parser.add_argument('-d', '--digits', default=5.5, type=float, help='Specifies the resolution of the measurement in digits.') | ||
| parser.add_argument('-s', '--samples-to-fetch', default=4, type=int, help='Specifies the number of measurements to fetch at a time.') | ||
| parser.add_argument('--total-samples', default=None, type=int, help='Stops fetching after this many samples and keeps the chart open until its window is closed; omit to run until the chart window is closed or Ctrl+C is pressed.') | ||
| parser.add_argument('-op', '--option-string', default='', type=str, help='Sets the initial value of certain attributes for the session.') | ||
| args = parser.parse_args(argsv) | ||
| example(args.resource_name, args.option_string, args.function, args.range, args.digits, args.samples_to_fetch, args.total_samples) | ||
|
|
||
|
|
||
| def main(): | ||
| _main(sys.argv[1:]) | ||
|
|
||
|
|
||
| def test_example(): | ||
| plt = pytest.importorskip('matplotlib.pyplot') | ||
| plt.switch_backend('Agg') # Avoid opening a chart window during the test | ||
| options = {'simulate': True, 'driver_setup': {'Model': '4082', 'BoardType': 'PXIe', }, } | ||
| example('PXI1Slot2', options, 'DC_VOLTS', 10, 5.5, 4, 10) | ||
|
|
||
|
|
||
| def test_main(): | ||
| plt = pytest.importorskip('matplotlib.pyplot') | ||
| plt.switch_backend('Agg') # Avoid opening a chart window during the test | ||
| cmd_line = ['--option-string', 'Simulate=1, DriverSetup=Model:4082; BoardType:PXIe', '--total-samples', '10', ] | ||
| _main(cmd_line) | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| main() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentionally skipped the LabVIEW STOP button behavior to keep the example simple.
The loop stops when the chart window is closed or Ctrl+C is pressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's certainly precedent for leaving out something like in our Python examples.
niscope_fetch_forever.py terminates its fetch while loop after fetching after a configured number of samples.
This, like that, is a continuous acquisition, so perhaps we should use a similar termination mechanism?
Does your current code update the graph continuously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to
niscope_fetch_forever.py, we now have a termination mechanism usingtotal_samples. The user can configure the total number of samples to acquire, and the acquisition will stop once that count is reached.If
total_samplesis not specified, the acquisition will continue until the user terminates it by pressing Ctrl+C or closing the chart window.Please let me know if this aligns with what you had in mind.
Yes, the graph is updated continuously as new measurements are fetched. After each fetch, the newly acquired measurements are added to the chart, and the graph is refreshed to display the latest measurements. The chart maintains a rolling window of the most recent 250 measurements.