Repository navigation
Adding Improve DC Noise Rejection example in NI-DMM - #2217
divakar-selvam07 wants to merge 19 commits into
Conversation
…into users/diva/add-nidmm-improve-dc-noise-rejection-example
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2217 +/- ##
==========================================
+ Coverage 86.40% 88.12% +1.71%
==========================================
Files 86 88 +2
Lines 21563 22832 +1269
==========================================
+ Hits 18631 20120 +1489
+ Misses 2932 2712 -220
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…dmm-improve-dc-noise-rejection-example # Conflicts: # docs/nidmm/examples.rst
|
This PR is ready for @Avinash2Suresh 's review. |
|
@jarnoldNI , the PR is ready for your review. |
|
If we're going to copy the example, should we adapt the example description, too? @marcoskirsch What do you think? |
@ni-jfitzger @marcoskirsch - I like the idea of adding a description like this to the examples. If we do it for this one, we should do it for all of the ones we're working on. |
| # For aperture times over 100 ms, enable AutoZero to compensate for drift. | ||
| # The DMM takes shorter measurements, applies a new AutoZero offset to each, | ||
| # averages them, and returns one value. |
There was a problem hiding this comment.
We're setting auto_zero, way up above. Does this comment need to be split?
Or maybe we set auto_zero down here?
There was a problem hiding this comment.
Maybe I'm nitpicking, but I feel like this comment could also be clearer. The property that gets set is auto_zero. AutoZero is the enum and it's not like we have a feature with that spelling. The user manual page title it "Auto Zero".
https://www.ni.com/docs/en-US/bundle/ni-dmm/page/auto-zero.html
@marcoskirsch Do you have any thoughts on this?
There was a problem hiding this comment.
@ni-jfitzger That makes sense. I’ve split the comment, placed the Auto Zero explanation beside auto_zero, and kept the averaging explanation beside number_of_averages. I’ve also corrected the spelling to “Auto Zero.”
…' of https://github.com/NI-velmurugan/nimi-python into users/diva/add-nidmm-improve-dc-noise-rejection-example
…dmm-improve-dc-noise-rejection-example
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
nidmm_improve_dc_noise_rejection.py, a Python adaptation of the LabVIEW “Improve DC Noise Rejection” example.List issues fixed by this Pull Request below, if any.
None
What testing has been done?