Update ni.protobuf.types dependency and corresponding code changes#137
Merged
Conversation
…abilities, and get tests passing by adding timing and scale mode information where needed.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ni-protobuf-types dependency to a newer prerelease and updates datastore-python code/tests to match the updated nitypes/protobuf waveform shapes (notably timing/scale metadata expectations).
Changes:
- Bump
ni-protobuf-typesto>=1.2.0dev1(prerelease) and refreshpoetry.lockaccordingly. - Update multiple acceptance tests to construct expected waveforms with explicit
Timing(...)(andNoneScaleMode()where applicable). - Adjust gRPC conversion logic to pass iterables directly into
nitypes.Vector(...)rather than materializing into lists.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/acceptance/test_publish_with_metadata.py | Updates expected AnalogWaveform construction to include new timing/scale metadata. |
| tests/acceptance/test_publish_measurement_batch_and_read_data.py | Updates expected batch AnalogWaveform values to include timing/scale metadata. |
| tests/acceptance/test_publish_measurement_and_read_data.py | Updates expected waveform values to include timing metadata (and adjusts imports). |
| src/ni/datastore/data/_grpc_conversion.py | Updates iterable→Vector conversion behavior for condition/measurement batch publishing. |
| pyproject.toml | Bumps ni-protobuf-types requirement to a newer prerelease and allows prereleases. |
| poetry.lock | Locks updated dependency versions and metadata after the dependency bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hunter-ni
reviewed
Jun 10, 2026
hunter-ni
reviewed
Jun 10, 2026
hunter-ni
reviewed
Jun 10, 2026
mjohanse-emr
approved these changes
Jun 10, 2026
mjohanse-emr
left a comment
Collaborator
There was a problem hiding this comment.
I'll defer to Hunter on the _grpc_conversion changes. The test changes look good to me, though.
hunter-ni
reviewed
Jun 11, 2026
hunter-ni
approved these changes
Jun 11, 2026
hunter-ni
left a comment
Contributor
There was a problem hiding this comment.
Approve with Suggestions
csjall
approved these changes
Jun 12, 2026
hunter-ni
reviewed
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
AB#3877568
Bubbling up changes from ni.protobuf.types to datastore-python.
Why should this Pull Request be merged?
This brings in changes from ni.protobuf.types. Prior to this, I published a new version of that package to be consumed here.
What testing has been done?
I did this in stages, i.e. make the expected code changes, see that there were several failing tests (11) with the change. Then I updated the ni.protobuf.types version and make more changes to the expected waveforms in several tests until they passed locally.