Repository navigation
fix(overlay): connector contrast, clipped tab-order layer, pill region (0.18.5) - #51
Merged
Merged
Conversation
…ill region (0.18.5) The tab-order connector was drawn at 0.7 opacity, about 2.5:1 on white, so it is now opaque (3.93:1 on white). The tab-order SVG overflowed the viewport, and a path crossing text below the fold made axe's color-contrast return needs-review for that text; the SVG is now clipped. Report mode keeps hiding the overlay because the scanned app may run an older one. The pill group is a region labelled "a11y devtools" for scanners that don't exclude the overlay. New real-Chromium spec e2e-overlay-scan reproduces both scan problems.
…es in the changelog The pill region is named "Accessibility developer tools" so tabbing in doesn't announce "a11y devtools" twice. New spec: the open menu panel stays inside the region. The changelog lists the backgrounds the connector was measured on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three overlay fixes for 0.18.5.
regionrule. The name differs from the switch's own "a11y devtools".New real-Chromium spec
e2e-overlay-scan.spec.tsfails without the fixes and passes with them. Unit specs cover the connector, the SVG overflow, the region, and the open menu panel staying inside the region. 440 tests pass.