Skip to content

Refresh relative due date display in task list #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xhon-pelushi wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −4
Open

Refresh relative due date display in task list #3235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/components/TaskBody.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ export default {
showCreateMultipleTasksModal: false,
multipleTasks: { numberOfTasks: 0, tasks: {} },
additionalTaskProperties: {},
now: Date.now(),
}
},
computed: {
Expand All @@ -291,7 +292,7 @@ export default {
dueDateShort() {
if (!this.task.completed) {
return this.task.dueMoment.isValid()
? this.task.dueMoment.calendar(null, {
? this.task.dueMoment.calendar(moment(this.now), {
// TRANSLATORS This is a string for moment.js. The square brackets escape the string from moment.js. Please translate the string and keep the brackets.
lastDay: t('tasks', '[Yesterday]'),
// TRANSLATORS This is a string for moment.js. The square brackets escape the string from moment.js. Please translate the string and keep the brackets.
Expand All @@ -305,7 +306,7 @@ export default {
: ''
} else {
return this.task.completedDateMoment.isValid()
? this.task.completedDateMoment.calendar(null, {
? this.task.completedDateMoment.calendar(moment(this.now), {
// TRANSLATORS This is a string for moment.js. The square brackets escape the string from moment.js. Please translate the string and keep the brackets.
lastDay: t('tasks', '[Completed yesterday]'),
// TRANSLATORS This is a string for moment.js. The square brackets escape the string from moment.js. Please translate the string and keep the brackets.
Expand All @@ -329,7 +330,7 @@ export default {
}
if (!this.task.completed) {
return this.task.dueMoment.isValid()
? this.task.dueMoment.calendar(null, {
? this.task.dueMoment.calendar(moment(this.now), {
// TRANSLATORS This is a string for moment.js. The square brackets escape the string from moment.js. Please translate the string and keep the brackets.
lastDay: t('tasks', '[Yesterday at] LT'),
// TRANSLATORS This is a string for moment.js. The square brackets escape the string from moment.js. Please translate the string and keep the brackets.
Expand All @@ -346,7 +347,7 @@ export default {
: ''
} else {
return this.task.completedDateMoment.isValid()
? this.task.completedDateMoment.calendar(null, {
? this.task.completedDateMoment.calendar(moment(this.now), {
// TRANSLATORS This is a string for moment.js. The square brackets escape the string from moment.js. Please translate the string and keep the brackets.
lastDay: t('tasks', '[Completed yesterday at] LT'),
// TRANSLATORS This is a string for moment.js. The square brackets escape the string from moment.js. Please translate the string and keep the brackets.
Expand Down Expand Up @@ -492,6 +493,18 @@ export default {
}
},

mounted() {
// Keep the relative due date (e.g. "Today", "Yesterday") up to date
// even if the task itself isn't modified while the component stays mounted.
this.nowInterval = setInterval(() => {
this.now = Date.now()
}, 60000)
},

beforeUnmount() {
clearInterval(this.nowInterval)
},

methods: {
t,
n,
Expand Down