Skip to content

fix(account-name): handling - #6956

Merged
alperozturk96 merged 2 commits into
masterfrom
fix/account-name-handling
Nov 13, 2026
Merged

fix(account-name): handling#6956
alperozturk96 merged 2 commits into
masterfrom
fix/account-name-handling

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue

  • Opening a file link from Talk (…/f/) showed "Associated account not found".
  • The link's server was compared with each account's saved server URL as an exact string, so letter case, a trailing /, /index.php, default ports or http vs https made it fail.

Android Common PR: nextcloud/android-common#1093

Android Files PR: nextcloud/android#17888

How to test?

  • Open account from Talk
  • Open same account in Files
  • Tap file link from Talk
  • It should open file in Files

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

This was referenced Oct 27, 2026
Open
Merged
@alperozturk96 alperozturk96 linked an issue Oct 27, 2026 that may be closed by this pull request
opening file links from talk -> error nextcloud/android#17573
Open
@alperozturk96 alperozturk96 mentioned this pull request Oct 27, 2026
Open
@github-actions

github-actions Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit a9f8e7c
Version 6956
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96 alperozturk96 added the 2. developing Work in progress label Oct 27, 2026
@alperozturk96 alperozturk96 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 27, 2026
@mahibi
mahibi force-pushed the fix/account-name-handling branch from 2e12922 to b7dfc17 Compare November 12, 2026 15:02
@alperozturk96
alperozturk96 force-pushed the fix/account-name-handling branch from b7dfc17 to be08922 Compare November 13, 2026 09:29
@alperozturk96
update lib
a9f8e7c 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings1716
Errors00

SpotBugs

CategoryBaseNew
Bad practice77
Correctness88
Dodgy code4040
Internationalization33
Malicious code vulnerability33
Performance77
Security1111
Total7979

@alperozturk96
alperozturk96 merged commit d766251 into master Nov 13, 2026
20 of 22 checks passed
@alperozturk96
alperozturk96 deleted the fix/account-name-handling branch November 13, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes
@daniele-verducci daniele-verducci Awaiting requested review from daniele-verducci

Assignees

No one assigned

Labels

3. to review Waiting for reviews AI assisted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opening file links from talk -> error

2 participants

@alperozturk96 @mahibi