fix(federation): avoid empty body on signed requests - #2993
Merged
Conversation
blizzz
approved these changes
Sep 11, 2026
…h doesn't geremoved Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
benjaminfrueh
force-pushed
the
fix/federation-http1
branch
from
September 11, 2026 20:39
ab5bbb7 to
dd847d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Federated signed requests with empty body are sent with
content-length: 0.On some setups this header doesn't reach the receiving instance, which then rejects the requests with error
missing content-length in header.Solution
Send a minimal non-empty body
{}instead of an empty string.This is a limitation in core
IncomingSignedRequest::verifyHeaders(), which requires thecontent-lengthheader even when the body is empty. Working around it here because a core fix would need its own PR innextcloud/server.🤖 AI (if applicable)