Skip to content

fix(import): avoid crash when table or view is deleted before import job runs #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silverkszlo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(import): avoid crash when table or view is deleted before import job runs #2987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09fdb11
fix(import): avoid crash when table or view is deleted before import …
silverkszlo Sep 7, 2026
af0c06b
fix(import): skip import job when target table or view is gone
silverkszlo Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions lib/BackgroundJob/ImportTableJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use OCA\Tables\Db\ViewMapper;
use OCA\Tables\Notification\NotificationHelper;
use OCA\Tables\Service\ImportService;
use OCP\AppFramework\Db\DoesNotExistException;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\BackgroundJob\QueuedJob;
use OCP\IUserManager;
Expand Down Expand Up @@ -47,6 +48,20 @@ public function run($argument): void {
$userId = $argument['user_id'];
$tableId = $argument['table_id'];
$viewId = $argument['view_id'];

try {
$view = $viewId ? $this->viewMapper->find($viewId) : null;
$targetTableId = $view?->getTableId() ?? $tableId;
if ($targetTableId === null) {
$this->logger->error('Import job was scheduled without a table or view id, skipping.');
return;
}
$table = $this->tableMapper->find($targetTableId);
} catch (DoesNotExistException $e) {
$this->logger->warning('Import skipped, table or view no longer exists: ' . $e->getMessage(), ['exception' => $e]);
return;
}

$oldUser = $this->userSession->getUser();
$importSuccess = false;

Expand Down Expand Up @@ -74,14 +89,10 @@ public function run($argument): void {
$this->userSession->setUser($oldUser);
}

if (!$tableId && $viewId) {
$tableId = $this->viewMapper->find($viewId)->getTableId();
}

if ($importSuccess) {
$this->activityManager->triggerEvent(
objectType: ActivityManager::TABLES_OBJECT_TABLE,
object: $this->tableMapper->find($tableId),
object: $table,
subject: ActivityManager::SUBJECT_IMPORT_FINISHED,
additionalParams: [
'importStats' => $importStats,
Expand All @@ -93,17 +104,17 @@ public function run($argument): void {
$notifySubject = ActivityManager::SUBJECT_IMPORT_FAILED;
}

if ($viewId) {
if ($view !== null) {
$this->notificationHelper->sendNotification(
objectType: ActivityManager::TABLES_OBJECT_VIEW,
object: $this->viewMapper->find($viewId),
object: $view,
subject: $notifySubject,
author: $userId
);
} else {
$this->notificationHelper->sendNotification(
objectType: ActivityManager::TABLES_OBJECT_TABLE,
object: $this->tableMapper->find($tableId),
object: $table,
subject: $notifySubject,
author: $userId
);
Expand Down
Loading