perf: Speed up fetching services from container - #64172
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
$this->has will almost always return true as it checks class_exists and also $this->server->has, so the if made no sense. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Building an exception object can be expensive, avoid building one only to fallback to server DI from applications. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
I think the flat array for aliases cannot work, at least not how I implemented it here. |
I’m not sure whether this is the good solution. What I’m not sure about is interactions between server and app containers when there are aliases, which may not be the same on all of them. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
I’m actually unsure, I pushed a commit going the other direction for now, I’ll look into this more in-depth later. |
Summary
Speed containers lookup by:
Checklist
3. to review, feature component)stable32)AI (if applicable)