feat(webauthn): Skip 2FA for user verified logins#62540
Open
mimi89999 wants to merge 1 commit into
Open
Conversation
mimi89999
requested review from
Altahrim,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
July 25, 2026 17:20
A WebAuthn login with user verification is already a second factor, so do not ask for an additional 2FA challenge Signed-off-by: Michel Le Bihan <michel@lebihan.pl>
mimi89999
force-pushed
the
feat/webauthn-skip-2fa
branch
from
July 25, 2026 17:35
a1172e1 to
cc13da9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A WebAuthn login with user verification is already a second factor, so do not ask for an additional 2FA challenge
Summary
WebAuthn optionally performs user verification: a PIN or a fingerprint is checked on the device itself. That is effectively MFA, something the user has plus something the user knows.
This PR skips the 2FA challenge for those logins. Keys without user verification still go through the usual challenge.
Checklist
3. to review, feature component)stable32)AI (if applicable)