fix(viewer): use the header height token for the document offset - #6069
Open
Darshan-upadhyay1110 wants to merge 1 commit into
Open
fix(viewer): use the header height token for the document offset#6069Darshan-upadhyay1110 wants to merge 1 commit into
Darshan-upadhyay1110 wants to merge 1 commit into
Conversation
Darshan-upadhyay1110
requested review from
elzody and
juliusknorr
as code owners
September 11, 2026 07:00
Darshan-upadhyay1110
force-pushed
the
darshan/private/viewer-header-height
branch
from
September 11, 2026 07:12
34dbd8e to
7dc37cd
Compare
- Nextcloud 35 reduces --header-height from 50px to 44px. - The fixed -50px offset now cuts off the top of the Collabora Online toolbar. - Use calc(var(--header-height) * -1) so the offset follows the theme. Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Darshan-upadhyay1110
force-pushed
the
darshan/private/viewer-header-height
branch
from
September 11, 2026 08:49
7dc37cd to
e5378f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: