Repository navigation
fix(sync): read response headers case-insensitively - #3443
Open
maximemoreillon wants to merge 1 commit into
Open
maximemoreillon wants to merge 1 commit into
maximemoreillon wants to merge 1 commit into
Conversation
Header names are case-insensitive (RFC 9110), but ETag, Last-Modified and X-Notes-API-Versions were looked up with their exact casing. Behind proxies that lowercase header names, such as Cloudflare or any HTTP/2 hop, the ETag and modified time were never stored, so every sync used pruneBefore=0 and downloaded every note in full. Refs nextcloud#2531 AI-assistant: Claude Code 2.1.325 (Claude Opus 5.5) Signed-off-by: Maxime Moreillon <m.moreillon@gmail.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, headers like
ETag,Last-ModifiedandX-Notes-API-Versionsare looked up with exact casing. However, header names should be case insensitive (RFC 9110).Some reverse proxies like Cloudflare rewrite header names in lowercase, which the notes app consequently ignores, which triggers a complete re-sync of all notes.
This PR Closes #2531 by having the header matching case-insensitive.
🖼️ Screenshots
No UI change
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)