Make pm.max_requests configurable - #2143
Open
m-breitbach wants to merge 2 commits into
Open
Conversation
added 2 commits
September 6, 2026 21:32
Signed-off-by: Moritz Breitbach <moritz.breitbach@moetek.de>
Signed-off-by: Moritz Breitbach <moritz.breitbach@moetek.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested, please review carefully. AI used for translations only.
Given how the config mechanism works, it is impossible to set the value to zero (for disabling the limit, the old behavior). I guess this is acceptable for now.
Anyways, the whole config mechanism is a bit wild. The default value lives in three places. I think in an ideal solution, there would be exactly one default defined in .cfg. One could think about displaying it in the ncp-config CLI, say, in gray, when the input field is emptied. Instead of 0, there could be a placeholder like 'auto', leaving 0 as actually possible value. Just thinking out loud.