fix: check tag while renaming

[madbob]

I've replicated the same checks done while creating a new tag also when renaming it (not a duplicate, not empty, not an hidden tag).

Please note that here I've also removed some unused code left in TagModal when TagItem was introduced (db38c4c).

Fixes #9058

[kesselb]

Thanks for the PR 👍

[Copilot]

Pull request overview

This PR updates the tag renaming flow to apply the same client-side validation used when creating tags (prevent hidden-system names, empty names, and duplicates), and removes unused legacy code from TagModal now that TagItem owns the edit/rename UI.

Changes:

• Add validation checks to tag renaming in TagItem (hidden tag name / duplicate / empty).
• Remove unused rename-related state and methods from TagModal.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/components/TagItem.vue	Adds rename-time validation (hidden/duplicate/empty) and reuses existing close behavior after successful rename.
src/components/TagModal.vue	Removes unused legacy rename helpers/state that are no longer used since TagItem handles renaming.

[madbob]

By the way: is there any reason why hiddenTags is in src/components/tags.js and not in src/util/tag.js?

[ChristophWurst]

is there any reason why hiddenTags is in src/components/tags.js and not in src/util/tag.js?

Not that I'm aware of

[ChristophWurst]

Tested and works!

Commented UX and architectural suggestions

[ChristophWurst]

Tested & works

[ChristophWurst]

/backport to stable5.10

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)