Repository navigation
[stable5.4] fix(a11y): give the file upload button an accessible name - #3922
Merged
Merged
Conversation
The upload button of a file question only holds an icon, so a screen reader announces it as "button" without saying what it does. axe reports it as `button-name`, which fails WCAG 4.1.2. The button now gets an `aria-label`. It says "Upload a file" for a question that takes one file and "Upload files" when more than one file is allowed. The visible text "Add new file as answer" stays where it is: it belongs to the label of the hidden file input, not to the button. Fixes #3839 Signed-off-by: v01dst <v01dst@users.noreply.github.com> Assisted-by: OpenCode:MiniMax-M3.1-Flash
The name of the upload button now comes from n(), so each language gets the plural forms it needs for the number of files a question allows. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Chartman123
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #3902