enh(performance): get deck share permissions in one query - #8359
Open
grnd-alt wants to merge 1 commit into
Open
Conversation
grnd-alt
force-pushed
the
improve/join-query-on-share-permissions
branch
from
September 10, 2026 08:37
c3ccc7a to
b8d3912
Compare
Signed-off-by: grnd-alt <git@belakkaf.net>
grnd-alt
force-pushed
the
improve/join-query-on-share-permissions
branch
from
September 10, 2026 09:29
b8d3912 to
3cae83a
Compare
Contributor
|
馃悽 Performance warning. |
benjaminfrueh
approved these changes
Sep 10, 2026
| * @param bool $allowDeleted | ||
| * @return array<int, array<Acl::PERMISSION_*, bool>> | ||
| */ | ||
| public function getPermissionsForCards(array $cardIds, ?string $userId = null, bool $allowDeleted = false): array { |
There was a problem hiding this comment.
The param $allowDeleted is currently unused and should be maybe removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.