feat: add GitHub download statistics for app developers#1796
Draft
miaulalala wants to merge 2 commits into
Draft
feat: add GitHub download statistics for app developers#1796miaulalala wants to merge 2 commits into
miaulalala wants to merge 2 commits into
Conversation
- Parse GitHub release asset URLs stored in AppRelease.download
- Extend GitHubClient with get_releases() to fetch per-asset download
counts from the GitHub API; also fix inverted auth header bug
- Add get_download_counts() to aggregate counts across releases,
grouping by repo to minimise API calls; non-GitHub URLs return null
- New API endpoint GET /api/v1/apps/{id}/downloads (owner/co-maintainer
only) returns JSON with version, channel, download_count per release
- New web page /apps/{id}/downloads shows the same data in a table,
linked from the app detail sidebar under a Developer section
- 18 new tests covering URL parsing, count fetching, deduplication,
and all HTTP permission scenarios
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHubClientwithget_releases()to fetch per-asset download counts from the GitHub API (and fixes a long-standing inverted auth header bug)get_download_counts()which groups releases by(owner, repo)to minimise API calls; non-GitHub URLs returnnullGET /api/v1/apps/{id}/downloads— owner/co-maintainer only, returns JSON list withversion,is_nightly,download,download_countper release/apps/{id}/downloadswith a table of the same data, linked from the app detail sidebar under a "Developer" section (visible only to owners/co-maintainers)Context
88.6% of the ~15k releases in the app store are hosted on GitHub using the standard
releases/downloadURL pattern, so the GitHub API covers the vast majority of apps without any changes to how developers register releases. Releases on other hosts (GitLab, self-hosted, etc.) shownull.A
GITHUB_API_TOKENshould be set in production settings to avoid the 60 req/hr unauthenticated rate limit.Test plan
python manage.py test nextcloudappstore.core.tests.test_github nextcloudappstore.api.v1.tests.test_app_download_stats🤖 Generated with Claude Code