Repository navigation
Conversation
Assisted-by: Codex:GPT-6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing metadata for an encrypted subfolder currently sets
encryptedUsersto an empty list. Gson serializes that as"users": [], although the E2EE RFC requires subfolders to omitusersand inherit the topmost metadata key. The web client can misclassify these directories as roots and fail the parent listing withCurrent user has no access to this folder.Set the subfolder's encrypted users to null so the existing Gson configuration omits the field. Root recipients and encrypted metadata keys remain present. Existing metadata is deserialized without normalizing the signed representation, so both omitted users and an existing empty array can still be verified.
The separate web compatibility fix for metadata already stored on servers is nextcloud/end_to_end_encryption#2312.
Validation: the new regression fails against the unmodified upstream source and all three tests pass after the fix. The tests cover inheriting the root key and omitting users for subfolders, retaining root recipients, and preserving the serialized representation of existing metadata.
spotlessKotlinCheck, Detekt, andlintGplayDebugpass. The Gradle SpotBugs launcher could not start its Java process on Windows; direct SpotBugs analysis of EncryptionUtilsV2 and its nested classes completed with no missing classes or analysis errors, and found no new report identities compared with the unmodified upstream bytecode (15 existing reports on each side).AI assistance: Codex (GPT-6) assisted with diagnosis, implementation, and testing. The contributor explicitly authorized submitting this pull request.