Repository navigation
Conversation
alab2296
force-pushed
the
fix/outdated-server-warning-dismiss
branch
from
November 14, 2026 08:53
56e94b5 to
8943492
Compare
Adds a preference to store the dismissed server version string. Before showing the warning, the current version is compared against the stored dismissed version. On dismiss, the version is saved so the warning does not reappear for the same server version. Fixes nextcloud#3855 Signed-off-by: alab2296 <alab2296@users.noreply.github.com>
alab2296
force-pushed
the
fix/outdated-server-warning-dismiss
branch
from
November 14, 2026 09:23
8943492 to
d7f5843
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3855
The outdated server version warning (snackbar) was shown repeatedly on every app start with no way to permanently dismiss it. The dismiss button existed but did nothing.
Changes
getDismissedOutdatedServerVersion()andsetDismissedOutdatedServerVersion(String)toAppPreferencesinterface andAppPreferencesImplFileDisplayActivity.showOutdatedServerWarningIfNeeded()to compare the current server version against the stored dismissed version before showing the warningSnackbarUtil.showServerOutdated()to accept an optionalonDismisscallback, which stores the dismissed version when the user taps DismissBehaviour
Test plan