Skip to content

refactor(base-activity): kotlin - #18043

Open
alperozturk96 wants to merge 4 commits into
masterfrom
refactor/base-activity-kotlin
Open

alperozturk96 wants to merge 4 commits into
masterfrom
refactor/base-activity-kotlin

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • Converts to Kotlin
  • Simplifies logic
  • Removes redundant theme setting calls

How to test?

  1. Fresh install login, use app
  2. Upgrade, use app
  3. Change theme

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.2.0 milestone Nov 12, 2026
@alperozturk96 alperozturk96 added 3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Nov 12, 2026
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
* Adapter delegating raw {@link SharedPreferences.OnSharedPreferenceChangeListener} calls with key-value pairs to
* respective {@link com.nextcloud.client.preferences.AppPreferences.Listener} method.
*/
static class ListenerRegistry implements SharedPreferences.OnSharedPreferenceChangeListener {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme listener don't need this.

@github-actions

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4646
Dodgy code125125
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2525
Security1515
Total250250

@github-actions

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit ed04dd2
Version 18043
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant