Skip to content

[stable-35.1.x] enable r8 only for dev for now #18032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alperozturk96 merged 3 commits into from
Nov 12, 2026
Merged

[stable-35.1.x] enable r8 only for dev for now #18032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a6ebfa
disable r8
alperozturk96 Nov 6, 2026
81c6a35
configure r8
alperozturk96 Nov 6, 2026
bafaac5
configure r8
alperozturk96 Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,6 @@ android {

buildTypes {
release {
optimization {
enable = true
}
buildConfigField("String", "NC_TEST_SERVER_DATA_STRING", "\"\"")
ndk {
abiFilters += allAbis
Expand All @@ -140,6 +137,9 @@ android {
enableUnitTestCoverage = project.hasProperty("coverage")
enableAndroidTestCoverage = project.hasProperty("coverage")
resConfigs("xxxhdpi")
optimization {
enable = true
}
ndk {
abiFilters += if (ciBuild) allAbis else localDebugAbis
}
Expand Down Expand Up @@ -168,6 +168,9 @@ android {
dimension = "default"
versionCode = 20220322
versionName = "20220322"
optimization {
enable = true
}
}

register("qa") {
Expand Down
7 changes: 0 additions & 7 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,6 @@ GRADLE_SIGNING_PROPERTIES = {
import("./common.Fastfile")

platform :android do

before_all do
gradleFile = "../app/build.gradle.kts"
content = File.read(gradleFile)
File.write(gradleFile, content.sub(/(optimization\s*\{\s*enable\s*=\s*)true/, '\\1false'))
end

## private lanes
desc "check if library is set correctly"
private_lane :checkLibrary do |options|
Expand Down
Loading