Skip to content

refactor(main-app) - #18010

Merged
alperozturk96 merged 16 commits into
masterfrom
refactor/main-app
Nov 11, 2026
Merged

refactor(main-app)#18010
alperozturk96 merged 16 commits into
masterfrom
refactor/main-app

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • Removes unused functions and variables from MainApp.
  • Converts BootupBroadcastReceiver, ReceiversHelper to Kotlin.
  • Makes context non-nullable.
  • Uses injections instead of re-creating.
  • De-duplicates init sync operations. Because MainApp.onCreate already runs same thing as BootupBroadcastReceiver. see: https://developer.android.com/reference/android/app/Application#onCreate. If BootupBroadcastReceiver is triggered before this MainApp will be always triggered as well.

Check logs on master see:

MainApp  16:40:03.917
BootupBroadcastReceiver 16:40:05.786.
  • De-duplicates set theme logic.

How to test?

  • Change theme from settings.
  • Reboot device and check logs for init operations.

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.2.0 milestone Nov 10, 2026
@alperozturk96 alperozturk96 added 3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) performance 🚀 Performance improvement opportunities (non-crash related) labels Nov 10, 2026
@github-actions

github-actions Bot commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 7acd7ea
Version 18010
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

github-actions Bot commented Nov 10, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4747
Dodgy code126126
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2626
Security1515
Total253253

@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.02655% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../owncloud/android/files/BootupBroadcastReceiver.kt 0.00% 16 Missing ⚠️
...java/com/owncloud/android/utils/ReceiversHelper.kt 84.09% 6 Missing and 1 partial ⚠️
...ud/client/migrations/AutoUploadEntriesMigration.kt 78.57% 2 Missing and 1 partial ⚠️
.../java/com/nextcloud/client/preferences/DarkMode.kt 70.00% 2 Missing and 1 partial ⚠️
app/src/main/java/com/owncloud/android/MainApp.kt 88.46% 2 Missing and 1 partial ⚠️
...owncloud/android/ui/dialog/ThemeSelectionDialog.kt 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alperozturk96
remove unused functions, variables
d2bce55 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
make context non-nullable, use injections instead construction
d1897a7 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
pass ArbitraryDataProvider
ae9d598 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Rename .java to .kt
05785d8 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
convert BootupBroadcastReceiver to kotlin
518a162 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Rename .java to .kt
0a40939 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
convert ReceiversHelper to kotlin
9c9ccd0 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/MainApp.kt
@alperozturk96
formatting
73af37a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
de-duplicate init sync operations
531125a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
de-duplicate init sync operations
2e1fe5d 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Rename .java to .kt
67fdb1f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
de-duplicate set theme
39e5ae4 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
de-duplicate set theme
91ae3c4 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
de-duplicate set theme
311d069 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
de-duplicate set theme
e5fa853 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
7acd7ea 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Nov 11, 2026

Copy link
Copy Markdown

stable35-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/18010-IT-stable35-12-32

@alperozturk96
alperozturk96 merged commit 0313c20 into master Nov 11, 2026
25 of 30 checks passed
@alperozturk96
alperozturk96 deleted the refactor/main-app branch November 11, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes

Assignees

No one assigned

Labels

3. to review performance 🚀 Performance improvement opportunities (non-crash related) ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud App 35.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @daniele-verducci