Skip to content

fix(navigation): to albums from assistant - #18009

Merged
alperozturk96 merged 1 commit into
masterfrom
fix/navigation-to-album
Nov 11, 2026
Merged

alperozturk96 merged 1 commit into
masterfrom
fix/navigation-to-album

Conversation

@alperozturk96

Copy link
Copy Markdown
Collaborator

Issue

java.lang.IllegalArgumentException:
    com.nextcloud.ui.composeActivity.ComposeActivity@f742071
    must implement ContainerActivity
    at com.owncloud.android.ui.fragment.albums.AlbumsFragment.onAttach(AlbumsFragment.kt:95)
    at androidx.fragment.app.Fragment.lambda$performAttach$2$androidx-fragment-app-Fragment(Fragment.java:3042)
    at androidx.fragment.app.Fragment$$ExternalSyntheticLambda8.run(D8$$SyntheticClass:0)
    at androidx.fragment.app.FragmentTracer.trace(FragmentTracer.kt:52)
    at androidx.fragment.app.Fragment.performAttach(Fragment.java:3042)
    at androidx.fragment.app.FragmentStateManager.attach(FragmentStateManager.java:509)
    at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:278)
    at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2193)
    at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2088)
    at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2031)
    at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:700)
    at android.os.Handler.handleCallback(Handler.java:1080)
    at android.os.Handler.dispatchMessageImpl(Handler.java:135)
    at android.os.Handler.dispatchMessage(Handler.java:126)
    at android.os.Looper.loopOnce(Looper.java:285)
    at android.os.Looper.loop(Looper.java:390)
    at android.app.ActivityThread.main(ActivityThread.java:9884)
    at java.lang.reflect.Method.invoke(Native Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:575)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:906)
Caused by: java.lang.ClassCastException:
    com.nextcloud.ui.composeActivity.ComposeActivity
    cannot be cast to
    com.owncloud.android.ui.fragment.FileFragment$ContainerActivity
    at com.owncloud.android.ui.fragment.albums.AlbumsFragment.onAttach(AlbumsFragment.kt:93)
    ... 19 more

How to test?

  1. Open Assistant screen
  2. Go to Albums

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 815a8b6
Version 18009
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.1.x

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the fix/navigation-to-album branch from 3a2eb69 to 815a8b6 Compare November 11, 2026 09:06
@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ty/drawer/navigation/DrawerMenuItemClickHandler.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4747
Dodgy code126126
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2626
Security1515
Total253253

@alperozturk96
alperozturk96 merged commit dcbfb71 into master Nov 11, 2026
25 checks passed
@alperozturk96
alperozturk96 deleted the fix/navigation-to-album branch November 11, 2026 11:10
@backportbot

backportbot Bot commented Nov 11, 2026

Copy link
Copy Markdown

The backport to stable-35.1.x failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-35.1.x
git pull origin stable-35.1.x

# Create the new backport branch
git checkout -b backport/18009/stable-35.1.x

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 815a8b69

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/18009/stable-35.1.x

Error: Failed to check for changes with origin/stable-35.1.x: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants