[alperozturk96]

Issue

The app crashed when the media player tried to load a track after the account was removed.

Exception com.nextcloud.client.network.ClientFactory$CreationException:
  at com.nextcloud.client.network.ClientFactoryImpl.createNextcloudClient (ClientFactoryImpl.java:51)
  at com.nextcloud.client.player.media3.datasource.PlaybackDataSourceFactory.createHttpDataSourceFactory (PlaybackDataSourceFactory.kt:48)
  at com.nextcloud.client.player.media3.datasource.PlaybackDataSourceFactory.createUpstreamDataSourceFactory$lambda$0 (PlaybackDataSourceFactory.kt:41)
  at com.nextcloud.client.player.media3.datasource.PlaybackDataSourceFactory$$ExternalSyntheticLambda0.createDataSource (D8$$SyntheticClass)
  at androidx.media3.datasource.cache.CacheDataSource$Factory.createDataSource (CacheDataSource.java:258)
  at com.nextcloud.client.player.media3.datasource.PlaybackDataSourceFactory.createDataSource (PlaybackDataSourceFactory.kt:37)
  at androidx.media3.exoplayer.source.ProgressiveMediaSource.createPeriod (ProgressiveMediaSource.java:435)
  at androidx.media3.exoplayer.source.MaskingMediaPeriod.createPeriod (MaskingMediaPeriod.java:134)
  at androidx.media3.exoplayer.source.MaskingMediaSource.onChildSourceInfoRefreshed (MaskingMediaSource.java:206)
  at androidx.media3.exoplayer.source.WrappingMediaSource.onChildSourceInfoRefreshed (WrappingMediaSource.java:155)
  at androidx.media3.exoplayer.source.WrappingMediaSource.onChildSourceInfoRefreshed (WrappingMediaSource.java:50)
  at androidx.media3.exoplayer.source.CompositeMediaSource.lambda$prepareChildSource$0$androidx-media3-exoplayer-source-CompositeMediaSource (CompositeMediaSource.java:119)
  at androidx.media3.exoplayer.source.CompositeMediaSource$$ExternalSyntheticLambda0.onSourceInfoRefreshed (D8$$SyntheticClass)
  at androidx.media3.exoplayer.source.BaseMediaSource.refreshSourceInfo (BaseMediaSource.java:96)
  at androidx.media3.exoplayer.source.ProgressiveMediaSource.notifySourceInfoRefreshed (ProgressiveMediaSource.java:556)
  at androidx.media3.exoplayer.source.ProgressiveMediaSource.prepareSourceInternal (ProgressiveMediaSource.java:425)
  at androidx.media3.exoplayer.source.BaseMediaSource.prepareSource (BaseMediaSource.java:276)
  at androidx.media3.exoplayer.source.CompositeMediaSource.prepareChildSource (CompositeMediaSource.java:124)
  at androidx.media3.exoplayer.source.WrappingMediaSource.prepareChildSource (WrappingMediaSource.java:241)
  at androidx.media3.exoplayer.source.MaskingMediaSource.createPeriod (MaskingMediaSource.java:120)
  at androidx.media3.exoplayer.MediaSourceList.createPeriod (MediaSourceList.java:341)
  at androidx.media3.exoplayer.MediaPeriodHolder.<init> (MediaPeriodHolder.java:126)
  at androidx.media3.exoplayer.ExoPlayerImplInternal.createMediaPeriodHolder (ExoPlayerImplInternal.java:415)
  at androidx.media3.exoplayer.ExoPlayerImplInternal.$r8$lambda$4ByVomVrDZGMrfXELlhTrFd0naQ (ExoPlayerImplInternal.java)
  at androidx.media3.exoplayer.ExoPlayerImplInternal$$ExternalSyntheticLambda3.create (D8$$SyntheticClass)
  at androidx.media3.exoplayer.MediaPeriodQueue.enqueueNextMediaPeriodHolder (MediaPeriodQueue.java:246)
  at androidx.media3.exoplayer.ExoPlayerImplInternal.maybeUpdateLoadingPeriod (ExoPlayerImplInternal.java:2776)
  at androidx.media3.exoplayer.ExoPlayerImplInternal.updatePeriods (ExoPlayerImplInternal.java:2753)
  at androidx.media3.exoplayer.ExoPlayerImplInternal.doSomeWork (ExoPlayerImplInternal.java:1458)
  at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage (ExoPlayerImplInternal.java:765)
  at android.os.Handler.dispatchMessage (Handler.java:102)
  at android.os.Looper.loopOnce (Looper.java:222)
  at android.os.Looper.loop (Looper.java:314)
  at android.os.HandlerThread.run (HandlerThread.java:67)

Changes

-PlaybackDataSourceFactory no longer creates clients. PlaybackDataSource now gets them in open().

• Uses ClientRepository instead of ClientFactory.
• Builds the delegate after the client is available.
• Stores the ownCloud client the same way.

How to test?

1. Play media
2. Remove account

[github-actions]

📱 QA build

Download	app-qa-debug.apk
QR code	Open the QR code for this download
Commit	311287b
Version	18008
Available until	7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

[github-actions]

SpotBugs

Category	Base	New
Bad practice	24	24
Correctness	47	47
Dodgy code	126	126
Experimental	1	1
Malicious code vulnerability	1	1
Multithreaded correctness	13	13
Performance	26	26
Security	15	15
Total	253	253

[codecov]

Codecov Report

❌ Patch coverage is 2.85714% with 34 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ent/player/media3/datasource/PlaybackDataSource.kt	0.00%	30 Missing ⚠️
...yer/media3/datasource/PlaybackDataSourceFactory.kt	20.00%	4 Missing ⚠️

📢 Thoughts on this report? Let us know!

[alperozturk96]

/backport to stable-35.1.x

[github-actions]

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.