[alperozturk96]

Issue

Exception java.lang.RuntimeException: An error occurred while executing doInBackground()
  at android.os.AsyncTask$4.done (AsyncTask.java:415)
  at java.util.concurrent.FutureTask.finishCompletion (FutureTask.java:445)
  at java.util.concurrent.FutureTask.setException (FutureTask.java:314)
  at java.util.concurrent.FutureTask.run (FutureTask.java:333)
  at android.os.AsyncTask$SerialExecutor$1.run (AsyncTask.java:305)
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1100)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:624)
  at java.lang.Thread.run (Thread.java:1571)
Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.dispatchCancelPendingInputEvents()' on a null object reference
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.ViewGroup.dispatchCancelPendingInputEvents (ViewGroup.java:4697)
  at android.view.View.cancelPendingInputEvents (View.java:21420)
  at android.app.Activity.cancelInputsAndStartExitTransition (Activity.java:5525)
  at android.app.Activity.startActivityForResult (Activity.java:5504)
  at androidx.activity.ComponentActivity.startActivityForResult (ComponentActivity.kt:675)
  at android.app.Activity.startActivityForResult (Activity.java:5443)
  at androidx.activity.ComponentActivity.startActivityForResult (ComponentActivity.kt:660)
  at com.owncloud.android.ui.activity.FileActivity.performCredentialsUpdate (FileActivity.java:501)
  at com.owncloud.android.ui.asynctasks.CheckRemoteWipeTask.doInBackground (CheckRemoteWipeTask.java:54)
  at com.owncloud.android.ui.asynctasks.CheckRemoteWipeTask.doInBackground (CheckRemoteWipeTask.java:26)
  at android.os.AsyncTask$3.call (AsyncTask.java:394)
  at java.util.concurrent.FutureTask.run (FutureTask.java:328)

Changes

• Converts to Kotlin
• Makes lifecycle-aware instead using AsyncTask
• Uses activity result launcher instead startActivityResult

How to test?

1. Install the app and log in with the browser login (not the nc:// link).
2. Open the file list.
3. Kick the app out on the server:
   • Browser: Settings → Security → Devices & sessions → ⋯ next to Nextcloud Android → Revoke
4. In the app, pull down to refresh.
5. Expected: the login screen opens and the app doesn't crash. [Crash happens due to life cycle, threading thus not easy to catch].

[codecov]

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...cloud/android/ui/asynctasks/CheckRemoteWipeTask.kt	0.00%	16 Missing ⚠️
...com/owncloud/android/ui/activity/FileActivity.java	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[github-actions]

📱 QA build

Download	app-qa-debug.apk
QR code	Open the QR code for this download
Commit	8f097dd
Version	17999
Available until	7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

[github-actions]

SpotBugs

Category	Base	New
Bad practice	24	24
Correctness	48	48
Dodgy code	128	128
Experimental	1	1
Malicious code vulnerability	1	1
Multithreaded correctness	13	13
Performance	26	26
Security	15	15
Total	256	256