Skip to content

fix(player): mode - #17995

Merged
alperozturk96 merged 1 commit into
masterfrom
fix/auto-play-music-file-without-config
Nov 11, 2026
Merged

fix(player): mode#17995
alperozturk96 merged 1 commit into
masterfrom
fix/auto-play-music-file-without-config

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Fixes: #17994

How to test?

  • Have some music files
  • Shuffle should play all files randomly
  • Repeat should repeat same file always
  • If nothing is selected it should just play current file

@alperozturk96
fix(player): mode
6411eb2 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.2.0 milestone Nov 9, 2026
@alperozturk96 alperozturk96 mentioned this pull request Nov 9, 2026
Closed
4 tasks done
@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...lient/player/media3/session/MediaSessionFactory.kt 11.11% 8 Missing ⚠️
.../nextcloud/client/player/model/PlaybackSettings.kt 50.00% 1 Missing ⚠️
...loud/client/player/ui/control/PlayerControlView.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4848
Dodgy code128128
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2626
Security1515
Total256256

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 6411eb2
Version 17995
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96

alperozturk96 commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.1.x

@alperozturk96
alperozturk96 merged commit f8212e3 into master Nov 11, 2026
27 checks passed
@alperozturk96
alperozturk96 deleted the fix/auto-play-music-file-without-config branch November 11, 2026 17:23
@backportbot backportbot Bot mentioned this pull request Nov 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 35.1.0

Development

Successfully merging this pull request may close these issues.

Built-in music player doesn't stop after current track

2 participants

@alperozturk96 @daniele-verducci