Repository navigation
Fix share button disappearing in favorites - #17978
alperozturk96 merged 3 commits into
Conversation
|
@tobiasKaminsky @alperozturk96 what do you think? I can revert the last commit, if that's the case! |
daniele-verducci
changed the title
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
| onSwapped: () -> Unit | ||
| ) { | ||
| this.onlyOnDevice = onlyOnDevice | ||
| searchType = null |
There was a problem hiding this comment.
swapDirectory can be called also when user in the favorites or shared thus setting null should not be the right way?
There was a problem hiding this comment.
I've done this because the searchType setting persisted when going back to All files after having visited Favorites. From my tests it seems to work, but I may have failed to test all the edge cases! What's the right way of doing this? Should I reset it only if navigating to All files?
There was a problem hiding this comment.
when i delete this line still working can u check?
There was a problem hiding this comment.
Yes, it's expected due to the following commit: there I enable the sharing icon also for the Favorites list and thus the button is always shown. I don't know if that's ok, as I see it was deliberately disabled, so it was by design. But it seems to work perfectly, ad if it's ok to keep it (the share button in favorites list), I could just delete this line and merge.
What do you think?
There was a problem hiding this comment.
@tobiasKaminsky share button should be enabled in favorite tab as well all the time right? I mean why I cannot share favorite file?
There was a problem hiding this comment.
I found this: d8b2a21823
I think that limitation is just obsolete
There was a problem hiding this comment.
I reverted the first commit so that, in case we decide to keep the share in favorites, this can be merged as is.
…k to normal files list Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
259073c to
5d79a3d
Compare
…oing back to normal files list" This reverts commit 31cb0f3. Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
/backport to stable-35.1.x |
|
Things to test...
|
Done this test with a 4th-level depth folder created from web: Result seems ok: |
Repro:
The real fix is in the first commit (the search type wasn't reset when swapping directrory), but I noticed we actually have the sharee data in the Favorites list, so not sure why the icon was hidden. I decided to just show it (second commit).
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)