Skip to content

Fix empty folder not updated in folder picker - #17977

Merged
alperozturk96 merged 1 commit into
masterfrom
fix/internal-109592-empty-folder-not-updated-in-picker
Nov 9, 2026
Merged

alperozturk96 merged 1 commit into
masterfrom
fix/internal-109592-empty-folder-not-updated-in-picker

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Fix empty folder not updated in folder picker due to callback handler never passed to RemoteOperation, that requires it to run the callback on the correct thread.

Repro:

  • Select a file, click Move/Copy
  • Enter an empty folder
  • The "Loading" text remained visible indefinitely, instead of showing "No files here"

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 383f090
Version 17977
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

… never passed to RemoteOperation

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@alperozturk96
alperozturk96 force-pushed the fix/internal-109592-empty-folder-not-updated-in-picker branch from a944ce1 to 383f090 Compare November 6, 2026 06:28
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4848
Dodgy code128128
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2626
Security1515
Total256256

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ncloud/android/ui/activity/FolderPickerActivity.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alperozturk96
alperozturk96 merged commit 65590d7 into master Nov 9, 2026
24 of 28 checks passed
@alperozturk96
alperozturk96 deleted the fix/internal-109592-empty-folder-not-updated-in-picker branch November 9, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants