Skip to content

Actionbar should alway show current folder name - #17975

Merged
alperozturk96 merged 2 commits into
masterfrom
fix/internal-71016-file-name-in-actionbar-when-notif-clicked
Nov 6, 2026
Merged

alperozturk96 merged 2 commits into
masterfrom
fix/internal-71016-file-name-in-actionbar-when-notif-clicked

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

This fixes file name shown in actionbar instead of current folder's when a download notification is clicked.

Repro:

  • Download large file
  • Click download notification
  • App comes up with right folder listing, but file title in actionbar instead of folder's

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@daniele-verducci daniele-verducci added this to the Nextcloud App 35.2.0 milestone Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit a8ef34a
Version 17975
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fragment.currentFile is only updated on the last line of listDirectory.

daniele-verducci and others added 2 commits November 6, 2026 14:59
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Co-authored-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
Signed-off-by: Daniele Verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
daniele-verducci force-pushed the fix/internal-71016-file-name-in-actionbar-when-notif-clicked branch from 62ec2c1 to a8ef34a Compare November 6, 2026 13:59
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4848
Dodgy code128128
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2626
Security1515
Total256256

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...wncloud/android/ui/activity/FileDisplayActivity.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alperozturk96
alperozturk96 merged commit 36cb082 into master Nov 6, 2026
25 checks passed
@alperozturk96
alperozturk96 deleted the fix/internal-71016-file-name-in-actionbar-when-notif-clicked branch November 6, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants