Skip to content

Meaningful storage name in picker - #17974

Merged
alperozturk96 merged 2 commits into
masterfrom
improv/meaningful-storage-name-in-picker
Nov 9, 2026
Merged

alperozturk96 merged 2 commits into
masterfrom
improv/meaningful-storage-name-in-picker

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Show meaningful names for the storages in the file/dir picker.
Hides the folders user can't access (i.e. /, /storage, /storage/emulated ...).
Uses user-readable names provided by Android's StorageManager, i.e. "Internal shared storage", "SanDisk SD card", "MyCustomSDCardName"...

(Fixes internal 109178)

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

stable35-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit cd96bb9
Version 17974
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
daniele-verducci force-pushed the improv/meaningful-storage-name-in-picker branch from 543df0a to cd96bb9 Compare November 6, 2026 17:05
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4848
Dodgy code128128
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2626
Security1515
Total256256

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...wncloud/android/ui/activity/UploadFilesActivity.kt 0.00% 11 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alperozturk96
alperozturk96 merged commit 9bf49ee into master Nov 9, 2026
27 of 31 checks passed
@alperozturk96
alperozturk96 deleted the improv/meaningful-storage-name-in-picker branch November 9, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants