Skip to content

Avoid picker navigation to affect main file list's one - #17958

Merged
alperozturk96 merged 2 commits into
masterfrom
fix/internal-109054-picker-navigation-brougth-to-main-files-list
Nov 5, 2026
Merged

alperozturk96 merged 2 commits into
masterfrom
fix/internal-109054-picker-navigation-brougth-to-main-files-list

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Howto repro:

  • Create folder
  • Enter folder A
  • Upload files
  • Select file
  • Tap Move/Copy
  • Navigate up to parent folder
  • Press Cancel
  • List of files shown is correctly from folder A, but header is from parent folder

🖼️ Screenshots

🏚️ Before 🏡 After
Screen_recording_20261104_180851.webm
Screen_recording_20261104_180759.webm

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...owncloud/android/ui/fragment/OCFileListFragment.kt 85.71% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 3f4417d
Version 17958
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96

Copy link
Copy Markdown
Collaborator

/backport to stable-35.1.x

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can achieve same thing without creating these and also we can get rid of the static field.

You can apply this patch to this branch and see changes.

p.patch

@daniele-verducci

Copy link
Copy Markdown
Contributor Author

Patch tested and applied, thanks Alper! I tought there was a specific reason for the static field, so I didn't dare to change it.

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
daniele-verducci force-pushed the fix/internal-109054-picker-navigation-brougth-to-main-files-list branch from 6f39c18 to 3f4417d Compare November 5, 2026 10:15
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4848
Dodgy code132132
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2828
Security1515
Total262262

@alperozturk96
alperozturk96 merged commit 7972a8e into master Nov 5, 2026
21 of 27 checks passed
@alperozturk96
alperozturk96 deleted the fix/internal-109054-picker-navigation-brougth-to-main-files-list branch November 5, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants