Skip to content

refactor(file-operation-helper): kotlin - #17956

Merged
alperozturk96 merged 2 commits into
masterfrom
refactor/file-operation-helper-kotlin
Nov 6, 2026
Merged

refactor(file-operation-helper): kotlin#17956
alperozturk96 merged 2 commits into
masterfrom
refactor/file-operation-helper-kotlin

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • Converts to Kotlin
  • Simplifies logic
  • Removes dead codes
  • Adds missing hardcoded user feedbacks to strings.xml

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.2.0 milestone Nov 4, 2026
@alperozturk96 alperozturk96 added 2. developing ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) AI assisted 3. to review and removed 2. developing labels Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 1b3da26
Version 17956
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96
Rename .java to .kt
996ce97 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
refactor(file-operation-helper): kotlin
1b3da26 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the refactor/file-operation-helper-kotlin branch from 02a9422 to 1b3da26 Compare November 5, 2026 05:49
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

stable35-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17956-IT-stable35-06-02

@codecov

codecov Bot commented Nov 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.42205% with 508 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...wncloud/android/ui/helpers/FileOperationsHelper.kt 3.43% 505 Missing and 1 partial ⚠️
.../com/nextcloud/ui/fileactions/FileActionHandler.kt 0.00% 1 Missing ⚠️
.../utils/extensions/FileOperationHelperExtensions.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4848
Dodgy code132128
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2826
Security1515
Total262256

daniele-verducci
daniele-verducci approved these changes Nov 5, 2026
View reviewed changes

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, good refactoring. Also, camera string wasn't even translated! Good catch!

@alperozturk96
alperozturk96 merged commit 2735487 into master Nov 6, 2026
27 of 28 checks passed
@alperozturk96
alperozturk96 deleted the refactor/file-operation-helper-kotlin branch November 6, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes

Assignees

No one assigned

Labels

3. to review AI assisted ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud App 35.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @daniele-verducci