Skip to content

refactor(main-app): kotlin - #17952

Merged
alperozturk96 merged 3 commits into
masterfrom
refactor/main-app-kotlin
Nov 10, 2026
Merged

refactor(main-app): kotlin#17952
alperozturk96 merged 3 commits into
masterfrom
refactor/main-app-kotlin

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • Converts to Kotlin
  • Simplifies logic and splits into classes

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@alperozturk96 alperozturk96 added 2. developing AI assisted ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Nov 4, 2026
@alperozturk96
alperozturk96 force-pushed the refactor/main-app-kotlin branch from 76a7a1a to 8ee8aeb Compare November 4, 2026 12:32
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

stable22-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17952-IT-stable22-13-21

@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.63636% with 176 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/src/main/java/com/owncloud/android/MainApp.kt 71.22% 64 Missing and 16 partials ⚠️
...ud/client/migrations/AutoUploadEntriesMigration.kt 18.57% 53 Missing and 4 partials ⚠️
...m/owncloud/android/datastorage/StoragePathFixer.kt 52.38% 5 Missing and 5 partials ⚠️
...wncloud/android/ui/activity/FileDisplayActivity.kt 20.00% 6 Missing and 2 partials ⚠️
...ud/client/notifications/AppNotificationChannels.kt 94.23% 2 Missing and 1 partial ⚠️
...owncloud/android/ui/fragment/OCFileListFragment.kt 25.00% 3 Missing ⚠️
...uthentication/GlobalPassCodeProtectionCallbacks.kt 91.66% 0 Missing and 2 partials ⚠️
.../main/java/com/nextcloud/client/NominatimClient.kt 0.00% 1 Missing ⚠️
...om/nextcloud/client/jobs/InternalTwoWaySyncWork.kt 0.00% 1 Missing ⚠️
...yer/media3/datasource/PlaybackDataSourceFactory.kt 0.00% 1 Missing ⚠️
... and 10 more

📢 Thoughts on this report? Let us know!

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.2.0 milestone Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 04579ec
Version 17952
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96
alperozturk96 force-pushed the refactor/main-app-kotlin branch 2 times, most recently from ed2ef70 to 9661691 Compare November 5, 2026 07:02
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

stable35-IT test failed, but no output was generated. Maybe a preliminary stage failed.

daniele-verducci
daniele-verducci requested changes Nov 10, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/MainApp.kt
powerManagementService: PowerManagementService,
backgroundJobManager: BackgroundJobManager,
clock: Clock,
viewThemeUtils: ViewThemeUtils?,

@daniele-verducci daniele-verducci Nov 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is never used, maybe can be removed

Comment thread app/src/main/java/com/owncloud/android/MainApp.kt
lateinit var clock: Clock

@Inject
lateinit var eventBus: EventBus

@daniele-verducci daniele-verducci Nov 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be used, I removed it and builds fine

Comment thread app/src/main/java/com/owncloud/android/MainApp.kt
fun string(@StringRes id: Int, args: Any?): String = getAppContext().getString(id, args)

@JvmStatic
fun getAppContext(): Context = appContext!!.get()!!

@daniele-verducci daniele-verducci Nov 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't not notice this not null assertion, but also the appContext is probably there all the time, so I guess it's fine

@alperozturk96
alperozturk96 force-pushed the refactor/main-app-kotlin branch from 9661691 to cfac208 Compare November 10, 2026 07:23
@alperozturk96
Rename .java to .kt
4d806e9 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
refactor(main-app): kotlin
2017c94 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/MainApp.kt
@alperozturk96
wip
04579ec 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the refactor/main-app-kotlin branch from cfac208 to 04579ec Compare November 10, 2026 07:54
@github-actions

github-actions Bot commented Nov 10, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4847
Dodgy code128126
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2626
Security1515
Total256253

@alperozturk96
alperozturk96 merged commit 2395169 into master Nov 10, 2026
24 of 30 checks passed
@alperozturk96
alperozturk96 deleted the refactor/main-app-kotlin branch November 10, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes

Assignees

No one assigned

Labels

3. to review AI assisted ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud App 35.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @daniele-verducci