Repository navigation
Fix back navigation to forbidden folder in file picker - #17937
Merged
alperozturk96 merged 1 commit intoNov 3, 2026
Merged
Conversation
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17937-IT-master-16-49 |
|
stable22-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17937-IT-stable22-16-52 |
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
alperozturk96
force-pushed
the
fix/picker-back-navigation-to-forbidden-folder
branch
from
November 3, 2026 06:42
34e82e1 to
7f8c416
Compare
alperozturk96
approved these changes
Nov 3, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
alperozturk96
deleted the
fix/picker-back-navigation-to-forbidden-folder
branch
November 3, 2026 07:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #17921 I didn't realize that navigating to a parent folder triggers an onBack event (!!), so introduced a bug that caused the screen to close when trying to navigate to a folder that can't be accessed.
This fixes that bug, makes code more readable and adds a documentation comment.
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)