Skip to content

Fix back navigation to forbidden folder in file picker - #17937

Merged
alperozturk96 merged 1 commit into
masterfrom
fix/picker-back-navigation-to-forbidden-folder
Nov 3, 2026
Merged

alperozturk96 merged 1 commit into
masterfrom
fix/picker-back-navigation-to-forbidden-folder

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

In #17921 I didn't realize that navigating to a parent folder triggers an onBack event (!!), so introduced a bug that caused the screen to close when trying to navigate to a folder that can't be accessed.
This fixes that bug, makes code more readable and adds a documentation comment.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 7f8c416
Version 17937
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@alperozturk96
alperozturk96 force-pushed the fix/picker-back-navigation-to-forbidden-folder branch from 34e82e1 to 7f8c416 Compare November 3, 2026 06:42
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4545
Dodgy code146146
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2828
Security1515
Total273273

@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...wncloud/android/ui/activity/UploadFilesActivity.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alperozturk96
alperozturk96 merged commit ca9f4ec into master Nov 3, 2026
25 checks passed
@alperozturk96
alperozturk96 deleted the fix/picker-back-navigation-to-forbidden-folder branch November 3, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants