[alperozturk96]

First common PR: nextcloud/android-common#1104

Changes

• Only does check if the device runs Android 17 or newer and the app targets SDK 37 or newer and server URL of the current account is local.
• Adds access local network permission for Android 17
• Warns user about the missing permission and recovers for failed uploads (only uploads because Downloads, offline sync and contacts/calendar backup aren't retried right away. They run again on their normal schedule. Only uploads restart immediately.)

Documentation

https://developer.android.com/privacy-and-security/local-network-permission

How to test?

1. make targetSdk = 37 from build.gradle

Behaviour

When user have Android 17 device and when the app opens:

Notification will be showed, if permission is missing and url is local:

If user puts the app in foreground, permission dialog will appear:

If user rejects it, snack-bar will appear:

[alperozturk96]

@tobiasKaminsky @daniele-verducci should we also check permission before any download, export etc?

I think current state of the PR is enough. Whoever have local network and Android 17 will see at least notification on app launch and native permission dialog. If they reject they will see snack-bar.

When they re-launch app they still see notification and snack-bar per app launch if the permission is missing. Adding check for each remote operation would be too much.

[github-actions]

stable35-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17934-IT-stable35-12-15

[github-actions]

📱 QA build

Download	app-qa-debug.apk
QR code	Open the QR code for this download
Commit	69ddacb
Version	17934
Available until	7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

[daniele-verducci]

should we also check permission before any download, export etc?

I think on app startup is enough: if the user just upgraded to 17, the phone has been rebooted and the message is shown as soon as the app is started

[daniele-verducci]

Working as intended

[codecov]

Codecov Report

❌ Patch coverage is 22.91667% with 148 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...t/network/local/LocalNetworkPermissionRequester.kt	21.73%	52 Missing and 2 partials ⚠️
...ent/network/local/LocalNetworkPermissionHandler.kt	20.75%	41 Missing and 1 partial ⚠️
...xtcloud/client/network/local/LocalNetworkRoutes.kt	22.22%	20 Missing and 1 partial ⚠️
...tcloud/client/network/local/LocalNetworkAddress.kt	0.00%	18 Missing ⚠️
...ud/android/authentication/AuthenticatorActivity.kt	36.36%	7 Missing ⚠️
...wncloud/android/ui/activity/FileDisplayActivity.kt	70.00%	3 Missing ⚠️
.../java/com/owncloud/android/utils/PermissionUtil.kt	0.00%	2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[github-actions]

stable22-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17934-IT-stable22-08-47

[github-actions]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17934-IT-master-08-48

[github-actions]

SpotBugs

Category	Base	New
Bad practice	24	24
Correctness	45	45
Dodgy code	145	145
Experimental	1	1
Malicious code vulnerability	1	1
Multithreaded correctness	13	13
Performance	28	28
Security	15	15
Total	272	272