Skip to content

Fixed empty view not shown in Media #17920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alperozturk96 merged 3 commits into from
Nov 3, 2026
Merged

Fixed empty view not shown in Media #17920

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fc9fa2
Fixed empty view not triggered in Media due to EmptyRecyclerView stil…
daniele-verducci Oct 30, 2026
fec574b
Oneliner with null casting for setHasFooter
daniele-verducci Nov 2, 2026
3ec1c78
Spotless
daniele-verducci Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,8 @@ class GalleryFragment :
}

override fun setAdapter(args: Bundle?) {
(recyclerView as? EmptyRecyclerView)?.setHasFooter(false)

galleryAdapter = GalleryAdapter(
requireContext(),
accountManager.user,
Expand All @@ -226,11 +228,6 @@ class GalleryFragment :
galleryAdapter?.setHasStableIds(true)
setRecyclerViewAdapter(galleryAdapter)

// update the footer as there is no footer shown in media view
if (recyclerView is EmptyRecyclerView) {
(recyclerView as EmptyRecyclerView).setHasFooter(false)
}

binding?.paginationProgress?.let {
viewThemeUtils.platform.colorCircularProgressBar(it, ColorRole.PRIMARY)
}
Expand Down
Loading