Skip to content

Fix missing share icon for newly-created files until a folder sync happens - #17919

Merged
alperozturk96 merged 4 commits into
masterfrom
fix/17915-missing-share-icon
Nov 4, 2026
Merged

alperozturk96 merged 4 commits into
masterfrom
fix/17915-missing-share-icon

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #17915 and internal 109064

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit bbf0601
Version 17919
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96
alperozturk96 force-pushed the fix/17915-missing-share-icon branch from 0a72fe8 to cd26a95 Compare November 2, 2026 06:20
@daniele-verducci

Copy link
Copy Markdown
Contributor Author

Right now this fixes #17915 but, apparently, not internal 109064, so setting it "developing".

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4545
Dodgy code146146
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2828
Security1515
Total273273

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...com/nextcloud/utils/extensions/OCFileExtensions.kt 0.00% 8 Missing ⚠️
...oid/operations/CreateShareWithShareeOperation.java 0.00% 1 Missing ⚠️
.../owncloud/android/operations/UnshareOperation.java 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

daniele-verducci and others added 4 commits November 4, 2026 12:34
…the sharee icon until next folder sync

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>

# Conflicts:
#	app/src/main/java/com/nextcloud/utils/extensions/OCFileExtensions.kt
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the fix/17915-missing-share-icon branch from 0c937f1 to bbf0601 Compare November 4, 2026 09:36
@alperozturk96
alperozturk96 merged commit ae13976 into master Nov 4, 2026
21 of 24 checks passed
@alperozturk96
alperozturk96 deleted the fix/17915-missing-share-icon branch November 4, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share folder: item in list is missing share icon, then it has wrong one, then appears right one

2 participants