[daniele-verducci]

Fix QR login when enforced servers are not defined

How to repro:

• Use the default Nextcloud app with no enforced servers
• On web, go to Settings -> Security -> App password
• Create app password and click Show QR Code
• Install app on device, click login button
• Click QRcode icon under server address textfield
• Scan the QR and click Yes when asked confirmation
• The app reports "Server not allowed"

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

• The content of this PR was partly or fully generated using AI (N/A)

[daniele-verducci]

If enforced servers list is not defined, the default should be true (= any server is allowed).
This was already present before the kotlin refactoring:

    private boolean checkAllowedServers(@NotNull String server) {
        String webviewLogin = getString(R.string.webview_login_url);

        if (!webviewLogin.isEmpty()) {
            if (webviewLogin.startsWith(server)) {
                return true;
            }
        }

        String enforcedServerList = getString(R.string.enforce_servers);

        if (!enforcedServerList.isEmpty()) {
            ArrayList<EnforcedServer> enforcedServers = new Gson().fromJson(enforcedServerList,
                                                                            new TypeToken<ArrayList<EnforcedServer>>() {
                                                                            }
                                                                                .getType());

            for (EnforcedServer enforcedServer : enforcedServers) {
                if (enforcedServer.getUrl().startsWith(server)) {
                    return true;
                }
            }
        }

        return false;    // <-- HERE
    }

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	24	24
Correctness	51	47
Dodgy code	148	146
Experimental	1	1
Malicious code vulnerability	1	1
Multithreaded correctness	20	20
Performance	28	28
Security	15	15
Total	288	282

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...roid/authentication/server/EnforcedServerPolicy.kt	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[github-actions]

📱 QA build

Download	app-qa-debug.apk
QR code	Open the QR code for this download
Commit	ee6fa54
Version	17900
Available until	7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.