Skip to content

refactor(authenticator-activity): kotlin - #17891

Merged
alperozturk96 merged 6 commits into
masterfrom
refactor/authenticator-activity-kotlin
Oct 28, 2026
Merged

alperozturk96 merged 6 commits into
masterfrom
refactor/authenticator-activity-kotlin

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • Converts to Kotlin
  • Simplifies logic.
  • Splits into smaller classes.
  • Uses non-deprecated APIs such as coroutines instead async task.

How to test?

  • Login via url
  • Login via QR Code
  • Login via deep link (debug login)
  • Add account

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.1.0 milestone Oct 27, 2026
@alperozturk96 alperozturk96 added 3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) AI assisted labels Oct 27, 2026
@github-actions

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 3fd412d
Version 17891
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness5147
Dodgy code148147
Experimental11
Malicious code vulnerability11
Multithreaded correctness2020
Performance2828
Security1515
Total288283

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alper,
all the login modes works but not the QR login. It says Server not allowed.
Relevant logs:

2026-10-28 12:54:35.497 23278-23278 com.blikoo...ityHandler com.nextcloud.android.qa             D  Got auto-focus message
2026-10-28 12:54:35.891 23278-23278 com.blikoo...ityHandler com.nextcloud.android.qa             E  Got decode succeeded message
2026-10-28 12:54:35.899 23278-23278 QRScannerQRCodeActivity com.nextcloud.android.qa             D  Got scan result from user loaded image :nc://login/user:daniele.verducci@nextcloud.com&password:aXqkp-LqP6r-iJT8n-84JYy-t2PjC&server:https://daily.ltd2.nextcloud.com
2026-10-28 12:54:35.931 23278-23278 QrCodeActivity          com.nextcloud.android.qa             D  onPause() ending
2026-10-28 12:54:36.742 23278-23278 AuthenticatorActivity   com.nextcloud.android.qa             D  onStart() starting
2026-10-28 12:54:36.846 23278-23278 AuthenticatorActivity   com.nextcloud.android.qa             D  onResume() starting
2026-10-28 12:54:37.419 23278-23278 QrCodeActivity          com.nextcloud.android.qa             D  onStop() ending
2026-10-28 12:54:37.429 23278-23278 QrCodeActivity          com.nextcloud.android.qa             D  onDestroy() ending
2026-10-28 12:54:37.582 23278-24794 loud.android.q          com.nextcloud.android.qa             I  Background concurrent copying GC freed 12305(1100KB) AllocSpace objects, 45(13MB) LOS objects, 49% free, 11MB/23MB, paused 90us total 155.538ms
2026-10-28 12:54:37.585 23278-24796 MediaPlayer-JNI         com.nextcloud.android.qa             W  MediaPlayer finalized without being released
2026-10-28 12:54:40.800 23278-24834 OpenGLRenderer          com.nextcloud.android.qa             D  endAllActiveAnimators on 0x7062a49d00 (RippleDrawable) with handle 0x70de3dd580
2026-10-28 12:54:40.828   986-4190  InputDispatcher         system_server                        E  Window handle Window{f0232a9 u0 com.nextcloud.android.qa/com.owncloud.android.authentication.AuthenticatorActivity} has no registered input channel
2026-10-28 12:54:40.831 23278-23278 AuthenticatorActivity   com.nextcloud.android.qa             W  Login rejected, server is not allowed: https://daily.ltd2.nextcloud.com
2026-10-28 12:54:40.843   986-1006  InputDispatcher         system_server                        E  Window handle Window{f0232a9 u0 com.nextcloud.android.qa/com.owncloud.android.authentication.AuthenticatorActivity} has no registered input channel

Tried with two different instances, same result. Also tried to build the app from AS instead of using QR build just in case was related to package name, but same result.

@daniele-verducci
daniele-verducci self-requested a review October 28, 2026 13:17
@daniele-verducci

Copy link
Copy Markdown
Contributor

all the login modes works but not the QR login. It says Server not allowed.

Update: this seems to happen randomly also on master, so it's not caused by this PR.

@alperozturk96
alperozturk96 merged commit 4b7a087 into master Oct 28, 2026
31 of 34 checks passed
@alperozturk96
alperozturk96 deleted the refactor/authenticator-activity-kotlin branch October 28, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants