Skip to content

Fix local/remote image file comparison - #17826

Merged
alperozturk96 merged 4 commits into
masterfrom
fix/internal-105127
Oct 22, 2026
Merged

Fix local/remote image file comparison#17826
alperozturk96 merged 4 commits into
masterfrom
fix/internal-105127

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@codecov

codecov Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nextcloud/utils/extensions/RemoteFileExtensions.kt 75.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@daniele-verducci
daniele-verducci marked this pull request as ready for review October 15, 2026 12:20
@daniele-verducci daniele-verducci added this to the Nextcloud App 35.1.0 milestone Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 332f6f5
Version 17826
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

alperozturk96
alperozturk96 requested changes Oct 21, 2026
View reviewed changes
Comment thread app/src/androidTest/java/com/nextcloud/extensions/RemoteFileExtensionsImageTest.kt
}

@Test
fun testAreImageDimensionsSameWhenLocalFileIsNotImage_ShouldReturnTrue() {

@alperozturk96 alperozturk96 Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow the conventions used in the rest of the project.

For example, we could use testAreImageDimensionsSameWhenLocalFileIsNotImageShouldReturnTrue or like

Image , as seen in `ManualAsyncRunnerTest` or `OCFileDepthTests`.

In the long run, we should decide which naming convention to follow consistently.

@daniele-verducci daniele-verducci Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but it fails with "Identifier not allowed in Android projects".
Asked Claude to explain and it says it's an instrumented test and is then compiled in DEX, where spaces aren't supported until SDK 30. I can't move it to the normal tests because it uses Bitmap from android.graphics

daniele-verducci and others added 4 commits October 21, 2026 17:15
@daniele-verducci
Fix: areImageDimensionsSame remote file check is now symmetric to loc…
300eb6f 
…al one (it doesn't fail when dimensions are unknown)

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Implemented tests
5d84351 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>

# Conflicts:
#	app/src/main/java/com/nextcloud/utils/extensions/RemoteFileExtensions.kt
@alperozturk96 @daniele-verducci
rebase
62e0686 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@daniele-verducci
Refactored tests
332f6f5 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@github-actions

github-actions Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness5151
Dodgy code159159
Experimental11
Malicious code vulnerability11
Multithreaded correctness2020
Performance2828
Security1616
Total300300

@alperozturk96
alperozturk96 merged commit b68e602 into master Oct 22, 2026
24 of 27 checks passed
@alperozturk96
alperozturk96 deleted the fix/internal-105127 branch October 22, 2026 06:55
@github-actions

github-actions Bot commented Oct 30, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review feedback-requested

Projects

None yet

Milestone

Nextcloud App 35.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@daniele-verducci @alperozturk96