[alperozturk96]

Implements: #17574

Test scenarios: opening a file from the file list

"Changed" means the file was edited on the web and the app noticed it during the folder refresh. To get there: edit the file on the web, stay in the folder and wait ~15s before tapping.

#	Tapped file in the file list	Before	After
1	Image that isn't downloaded, unchanged	Preview opens, sometimes after a server check	Preview opens immediately, no dialog
2	Image that isn't downloaded, changed	Loading dialog while the full image downloads, then preview	Preview opens immediately with the resized image, no dialog
3	Downloaded text file, unchanged	Preview opens, sometimes after a server check	Preview opens immediately, no dialog
4	Downloaded text file, changed	Loading dialog while syncing, then preview	Syncs in the background, then preview shows the new content, no dialog
5	Downloaded text file, changed on the web and edited locally (conflict)	Loading dialog, then conflict screen	Conflict screen opens, no dialog
6	Audio file that is still downloading, changed	Loading dialog while syncing, then player	Syncs in the background, then player opens, no dialog
7	Downloaded pdf, docx or other file, unchanged	Loading dialog and full sync on every tap, then external app	External app opens immediately, no dialog
8	Downloaded pdf, docx or other file, changed	Loading dialog while syncing, then external app	Syncs in the background, then external app opens the new version, no dialog
9	Downloaded pdf, docx or other file, conflict	Loading dialog, then conflict screen	Conflict screen opens, no dialog

[github-actions]

📱 QA build

Download	app-qa-debug.apk
QR code	Open the QR code for this download
Commit	908a7e3
Version	17725
Available until	7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

[codecov]

Codecov Report

❌ Patch coverage is 16.12903% with 104 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...cloud/android/ui/helpers/FileOperationsHelper.java	0.00%	51 Missing ⚠️
...oud/android/operations/RefreshFolderOperation.java	28.57%	22 Missing and 3 partials ⚠️
...wncloud/android/ui/activity/FileDisplayActivity.kt	29.16%	16 Missing and 1 partial ⚠️
...oud/android/operations/SynchronizeFileOperation.kt	0.00%	6 Missing ⚠️
...com/nextcloud/utils/extensions/OCFileExtensions.kt	0.00%	5 Missing ⚠️

📢 Thoughts on this report? Let us know!

[alperozturk96]

If I try to open the .md file from file list, it triggers the public void startSyncForFileAndIntent(OCFile file, Intent intent) are we going to check that logic as well?

Because internally it still calls

private void syncFileOrFolder(OCFile file, User user, FileDataStorageManager storageManager) thus R.string.sync_in_progress will be shown.

Apparently openFile functions is not the only one. @tobiasKaminsky

[daniele-verducci]

The app feels very fast after this change! Opening any downloaded file is very snappy!

[github-actions]

SpotBugs

Category	Base	New
Bad practice	24	24
Correctness	45	45
Dodgy code	146	146
Experimental	1	1
Malicious code vulnerability	1	1
Multithreaded correctness	18	13
Performance	28	28
Security	15	15
Total	278	273