feat: Ensure Nextcloud code use strict comparaison - #105
Open
CarlSchwan wants to merge 2 commits into
Open
CarlSchwan wants to merge 2 commits into
CarlSchwan wants to merge 2 commits into
Conversation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
nickvergessen
approved these changes
Sep 3, 2026
CarlSchwan
force-pushed
the
carl/strict-comparaison
branch
from
September 24, 2026 12:26
da15883 to
63c145d
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/strict-comparaison
branch
from
September 24, 2026 13:34
63c145d to
fe01cc6
Compare
come-nc
reviewed
Sep 24, 2026
| * To use it: | ||
| * $config = RectorConfig::configure()[…]->withImportNames(importShortClasses:false); | ||
| * $config->registerService(NextcloudNamespaceSkipVoter::class, tag:ClassNameImportSkipVoterInterface::class); | ||
| * $config->registerService(NextcloudNamespaceSkipVoter::class); |
Collaborator
There was a problem hiding this comment.
Why this change? I remember the tag as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
strict: truetoin_arraywhen possibleUse
===and!==instead of==and!=Motivation and context
Security and correctness
How has this been tested?
Types of changes
PR checklist