fix(images): page through images with video and audio again - #86
Merged
Merged
Conversation
skjnldsv
added
AI assisted
status: review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 89.59% 89.74% +0.14%
==========================================
Files 39 39
Lines 2855 2955 +100
Branches 599 635 +36
==========================================
+ Hits 2558 2652 +94
- Misses 290 295 +5
- Partials 7 8 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The old viewer put images, video and audio in one 'media' group, so a folder of photos and films paged through all of them, and a video found the picture of the same name beside it in its list, to show as its poster. The image handler lost the group in the move to this library: images paged on their own and videos never had a poster. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
fix/handler-peers
branch
from
October 2, 2026 06:02
6bc723e to
88999c9
Compare
skjnldsv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A video never showed the picture of the same name beside it as its poster (nextcloud/viewer#80), and images paged on their own instead of through the videos and sounds in the same folder.
The old viewer put images, video and audio in one
mediagroup (src/models/images.jsin nextcloud/viewer). The image handler here was written without it, so a video's list, which is its handler group, never held the picturefindLivePhotoPeerFromNamelooks for. This puts the image handler back inmedia. Navigation follows the group again across images, video and audio, and handlers keep receiving that navigation list asfiles, nothing more.The navigation e2e now pages from the first image through the video and sounds and round again, and checks that the sheet music, which has no group, still pages only among itself. The model test asserts the group. #87 builds on this for the poster after a replay, with an e2e test that has a video and its poster side by side.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.