Skip to content

feat(1secure): rename to 1Secure AI Security and keep it off production - #1851

Merged
jth-nw merged 2 commits into
devfrom
feat/1secure-beta-dev-only
Nov 9, 2026
Merged

jth-nw merged 2 commits into
devfrom
feat/1secure-beta-dev-only

Conversation

@jth-nw

@jth-nw jth-nw commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #1850 with two changes.

1. Rename. The product is called 1Secure AI Security, so the ID, folder, sidebar, and URL change from 1securebeta to 1secureaisecurity (/docs/1secureaisecurity). The beta page only existed on docs-dev briefly, so there is no redirect.

2. Keep it off production. The daily dev → main sync is a plain merge, so the unlisted product would reach docs.netwrix.com at the next sync. This adds a devOnly product flag:

  • products.js leaves devOnly products out of PRODUCTS when APP_EXTERNAL_URL is the production host (the same isIndexableSite check noIndex uses). No plugin, routes, or pages are built for them on production.
  • docs-dev and local builds are unchanged: the product is still built there.
  • 1secureaisecurity is flagged devOnly: true. To release it, remove the flag.
  • The files still merge to main with the rest of dev, as before. They are public on GitHub either way; this keeps them off the production site.

Test plan

  • node --test src/config/products.test.mjs (added to test:scripts): production host drops the product; docs-dev, localhost, and an unset URL keep it
  • APP_EXTERNAL_URL=https://docs.netwrix.com DOCS_PRODUCT=1secure npm run build: no docs/1secureaisecurity output, and no mention in robots.txt or sitemap.xml
  • APP_EXTERNAL_URL=https://docs-dev.netwrix.com DOCS_PRODUCT=1secureaisecurity npm run build: builds, pages are noindex, nofollow
  • CI build on this PR (runs with the dev environment URL, so it doesn't exercise the production filter; the checks above do)

Merge before the next sync (16:00 UTC) so the product never reaches production.

🤖 Generated with Claude Code

Adds a devOnly product flag. products.js leaves devOnly products out of
PRODUCTS when APP_EXTERNAL_URL is the production host (docs.netwrix.com),
so the beta is built on docs-dev and locally but gets no plugin, routes,
or pages on production, even though its files merge to main in the daily
sync. Remove the flag to release the product.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@jth-nw jth-nw changed the title feat(1secure): keep the 1Secure Beta product off production keep unlisted product off production Nov 9, 2026
Renames the product ID, folder, sidebar, and name to 1secureaisecurity /
1Secure AI Security. The URL is now /docs/1secureaisecurity.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@jth-nw
jth-nw requested a review from a team as a code owner November 9, 2026 23:31
@jth-nw jth-nw changed the title keep unlisted product off production feat(1secure): rename to 1Secure AI Security and keep it off production Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Documentation PR Review

Editorial Review

docs/1secureaisecurity/index.md

No issues found. The new page keeps the same structure and wording as the placeholder it replaces, with the product name updated to Netwrix 1Secure AI Security in the title, description, heading, and body. The {/* TODO */} placeholder doesn't render, so readers won't see it.

docs/1securebeta/index.md

No issues found. This PR deletes the file and adds no lines to it.

Summary

0 editorial suggestions across 2 files. Vale and Dale issues are auto-fixed separately.


What to do next:

Comment @claude on this PR followed by your instructions to get help:

  • @claude fix all issues — fix all editorial issues
  • @claude help improve the flow of this document — get writing assistance
  • @claude explain the voice issues — understand why something was flagged

You can ask Claude anything about the review or about Netwrix writing standards.

Automated fixes are only available for branches in this repository, not forks.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Auto-Fix Summary

0 issues fixed, 0 skipped across 2 files

Ask @claude on this PR if you'd like an explanation of any fix.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Code Review

No correctness issues found.

What I checked:

  • products.js filter: devOnly products are dropped only when APP_EXTERNAL_URL is set and isIndexableSite returns true. Every consumer goes through PRODUCTS: plugin generation, routes, navbar, getActiveProducts, the robots.txt plugin, and the KB copy script. So production builds no plugin, routes, or pages for the product. The default docs plugin is disabled (docs: false), so nothing else picks up docs/1secureaisecurity/.
  • Malformed URL: isIndexableSite throws on a malformed APP_EXTERNAL_URL, but docusaurus.config.js already calls it on the same value. This PR adds no new way for the build to fail.
  • Client bundle: there's no process, so PRODUCTS is unfiltered in the browser. The client components that use it (VersionSwitcher, ProductMetaTags, searchUtils) only look up products or iterate over them. SearchBar and SearchPage already exclude noIndex products. None of them render the hidden product, so there's no SSR/hydration mismatch. The product's name and metadata still ship in the production JS bundle. That's fine given the files are public on GitHub, as the PR notes.
  • Rename: no 1securebeta references are left in the repo (config, sidebars, CODEOWNERS, scripts). The sidebar rename is 100% similarity.
  • Tests: query-string imports re-evaluate products.js for each case, and the env var is restored in finally. Adding the test to test:scripts is correct.
  • No workflow changes.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Auto-Fix Summary

0 issues fixed, 0 skipped across 2 files

Ask @claude on this PR if you'd like an explanation of any fix.

@jth-nw
jth-nw merged commit 4cec16b into dev Nov 9, 2026
16 checks passed
@jth-nw
jth-nw deleted the feat/1secure-beta-dev-only branch November 9, 2026 23:42

This branch was previously deployed

1 inactive deployment
development — 19197f6a Deployed Nov 9, 2026 by jth-nw via build-and-deploy #5105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant