fix(llmops): extract a single valid JSON response - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6. Skip non-JSON brace literals when extracting checker responses, reject multiple JSON objects, and require a non-null findings array. Adds 54 regression cases; full tests, vet, build, and lint passed for this final parser implementation.
Prompt wording changes were evaluated and reverted: observed scores were slightly worse, with no demonstrated benefit. Original prompts are retained.
Greptile Summary
Tightens parsing of JSON-shaped LLM checker responses.
Confidence Score: 5/5
The PR appears safe to merge, with no new actionable issues introduced since the previous review.
No blocking or non-blocking findings remain in the reviewed changes.
Important Files Changed
Reviews (2): Last reviewed commit: "fix(llmops): restore prompts after incon..." | Re-trigger Greptile