feat(blobs): accept a region for site-wide stores - #773
Conversation
The client already forwarded a `region` supplied to `getStore`, but the option was absent from `GetStoreOptions`, so TypeScript rejected it and nothing documented it. Add it to the public interface. Behaviour is unchanged: site-wide stores still send no region unless one is given, and do not inherit `primaryRegion` from the environment the way deploy-scoped stores do. Tests cover both. Ref: RUN-3349
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughAdds an optional Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This makes existing site-wide store region selection available to TypeScript callers without changing the default behavior. Explicit regions are covered across request paths, with no remaining merge-blocking risk. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Comment |
@netlify/ai
@netlify/aws-lambda-compat
@netlify/blobs
@netlify/cache
@netlify/dev
@netlify/dev-utils
@netlify/headers
@netlify/images
@netlify/otel
@netlify/redirects
@netlify/runtime
@netlify/runtime-utils
@netlify/static
@netlify/types
@netlify/database-dev
@netlify/database
@netlify/database-proxy
@netlify/edge-functions-dev
@netlify/edge-functions
@netlify/functions-dev
@netlify/functions
@netlify/identity
commit: |
Adds
regiontoGetStoreOptions, so it can be passed togetStorefor site-wide stores.The client already forwarded and validated a
regiongiven togetStore— the option was just missing from the public type, so TypeScript rejected it and nothing documented it. This makes it supported rather than incidental.No behaviour change. Site-wide stores still send no region unless one is given, and still do not inherit
primaryRegionfrom the environment the way deploy-scoped stores do. Tests cover both defaults and the explicit option.