Release/7.0.0 rev10#337
Merged
Merged
Conversation
[NAE-2119] Fix menuItem
- testing pipeline
- testing pipeline
- testing pipeline
- testing pipeline
- testing pipeline
- testing pipeline
- testing pipeline
- testing pipeline
- testing pipeline
- testing pipeline
- testing pipeline
- rework based on pr comments - fix tests
- add realm id request placeholder
- include not found error handling
- production env fix
- preconfigure nae.json for local development
- Replaced all instances of `UriService` with `PathService` for improved consistency and clarity in naming. Updated constructors, imports, and references throughout the codebase, including components, tests, and documentation. - Removed use of uri nodes across the frontend, and implemented use of string path instead of uri nodes
- Updated references to `_uriService` to `_pathService` in multiple components.
- Refactored `PathService` constructor to handle `pageSize` more robustly, including type validation and fallback logging. - Fixed improper binding in `navigation-double-drawer.component.html` for `routerLink`.
- Improved breadcrumbs redirection logic by adding null checks and appropriate error logging for missing targets. - Simplified and optimized left and right navigation item loading with reusable `processItems` and `getChildCasesFromPage` logic. - Enhanced error handling and loading state management to ensure robustness in edge cases.
- Added unit tests for `AbstractBreadcrumbsComponent` to validate redirection logic and error handling. - Enhanced test coverage for `AbstractNavigationDoubleDrawerComponent` by adding tests for menu state, sorting, and resize handling. - Updated `MockUriResourceService` with consistent root path conventions. - Extended `MockUserService` with logout and empty user functionality.
- Added unit tests for `AbstractBreadcrumbsComponent` to validate redirection logic and error handling. - Enhanced test coverage for `AbstractNavigationDoubleDrawerComponent` by adding tests for menu state, sorting, and resize handling. - Updated `MockUriResourceService` with consistent root path conventions. - Extended `MockUserService` with logout and empty user functionality.
- extended `MockUserService` logout functionality to notify user change via `_userChange$`.
- fix possible null pointer exception
Reorganized logging to ensure success messages are logged after error checks and refined error handling logic for file uploads. Added a null-safe access to file names and fixed missing return statement in front-action error handling.
Refined file upload error logging and improved event parsing logic to handle frontActions. Added unit tests to verify file upload and download methods, ensuring better component reliability. Updated test dependencies to support new functionality.
Added missing imports for AbstractFileListFieldComponent and invalid data token to the test file. Updated the test component's template to include a file input element with binding to allowed file types.
Implemented tests to verify that the download and upload methods are called successfully. These tests improve the coverage and ensure the methods function as expected.
Implemented tests to verify that the download and upload methods are called successfully. These tests improve the coverage and ensure the methods function as expected.
… validation - refactore checkKey function in enumeration-field.ts
… validation Ensure that null values are correctly handled in the validation logic of enumeration fields. This prevents unnecessary errors when null is passed as a control value.
Replaced `find` with `some` to improve code clarity and intent. The updated method now directly checks for the existence of a matching key, simplifying the logic while maintaining functionality.
[NAE-2435] Enumeration field with no choices does not properly handle validation
Updated the code to handle cases where the file name might be undefined during error logging. This change prevents runtime errors caused by null references when accessing the file list.
Simplifies the error handling logic by removing an unnecessary null check for `response.error`. This ensures the snackbar displays error messages consistently without redundant conditionals.
Extended `MockTaskResourceService` with additional file methods to simulate file uploads and downloads. Improved test coverage in `AbstractFileListDefaultFieldComponent` and `AbstractFileDefaultFieldComponent` with refined mock implementations and more detailed file operation simulations. Added new dependencies for test files.
Reordered the parsing and emission of changed fields after a successful file upload. This ensures consistent execution flow and enhances code clarity.
[NAE-2416] AbstractFileDefaultFieldComponent does not push upload event
- Added checks to block actions (add/remove/change) when fields are disabled. - Passed `UserComparatorService` to task panel components for additional checks. - Enhanced tests to validate behavior of disabled fields and tab selections. - Updated input templates to bind `disabled` state to `formControlRef.disabled`.
- Renamed `.search-icon` to `.prefix-icon` in SCSS. - Replaced `mat-icon` with `matPrefix` for input in HTML.
Refactored the CaseStringId model to include optional dependencies for elastic keyword resolution. Adjusted the CaseSearch.enum to rename the STRING_ID value to 'id' for consistency. This enhances functionality and improves flexibility in dependency management.
- Changed `login` field source from `email` to `username` in `createRequestBody`.
- Updated `puppeteer` dependency in `package.json` to version `~24.43.1`.
- Updated `puppeteer` dependency in `package.json` to version `~24.43.1`.
- Updated `puppeteer` dependency in `package.json` to version `~24.43.1`.
[NAE-2452] Pre-release bugfixes
|
Important Review skippedToo many files! This PR contains 292 files, which is 142 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (292)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preapration for release 7.0.0
Dependencies
No new dependencies were introduced.
Blocking Pull requests
There are no dependencies on other PR.
How Has Been This Tested?
Automated tests with manual testing.
Test Configuration
Checklist: