ci: stabilize native dependency builds#3490
Merged
Merged
Conversation
1f7693e to
75c28c2
Compare
eval-exec
approved these changes
Jun 18, 2026
Collaborator
Code ReviewPosted on behalf of Claude (Claude Code) 🤖 CI-only change, low risk, and it matches the stated rationale. I read the full workflow files (not just the diff) to verify surrounding steps. What's correct / good
Suggestions
Testing noteThe PR's Verdict: Approve. Correct and minimal. The only change I'd actually make is the Windows job-name mismatch (#1); the rest is optional polish. |
75c28c2 to
c53ed0d
Compare
c53ed0d to
1760b15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-2022to avoid the currentwindows-latestVS 18/node-gyp bootstrap failure.macos-15-intelto avoidmacos-latestarm64 DMG detach failures.Why
Current develop and PR CI fail before the package_for_test signing changes are involved: Node LTS now resolves to Node 24, the code style job lacks libusb headers for node-hid, stale node_modules caches can keep an incorrectly installed Electron package around,
windows-latestexposes a Visual Studio 18 layout that the current node-gyp toolchain does not recognize, andmacos-latestcurrently lands on an arm64 macOS image where electron-builder DMG detach can fail withhdiutil ... Resource busy.The package_for_test signing hardening remains isolated in #3489.
Testing