worktree-agent-a6372d4befea54672 - #22
Merged
Merged
Conversation
mail-list --format detailed only returned a minimal projection (from, id, receivedDateTime, subject), so no read-only verb could surface per-message read status or category tags — blocking any read-only client from enumerating unread, category-tagged mail without degrading to folder-level unread counts. Add isRead and categories to the Graph $select (and therefore the JSON output) for mail-list --format detailed. No new OAuth scope: both fields are readable under the existing Mail.Read grant. --format concise is unchanged. Closes #20 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011NWPnfcJ9JXDvRThCCUcCH
neilgfoster
commented
Jul 23, 2026
neilgfoster
left a comment
neilgfoster
left a comment
Owner
Author
There was a problem hiding this comment.
Adversarial review (isolated, cold pass):
No correctness bugs found.
Minor efficiency note: plugin/src/msgraph/verbs.py:124 — the $select clause now includes isRead,categories unconditionally for both --format concise and --format detailed (the sel string is built once regardless of args.format), so concise calls now transfer these extra fields over the wire even though they're not rendered. Not a defect — matches the existing single-$select pattern in this file — just worth noting if payload size/rate-limits matter for large mailboxes.
The .gitattributes/.gitignore additions are unrelated kord/speckit substrate scaffolding, no logic to review there.
… format Concise mail-list calls don't render isRead/categories, so requesting them in $select wasted bandwidth on every concise call. Now the extra fields are only added to the Graph $select when --format detailed is used; concise keeps the original minimal select. Addresses adversarial-review efficiency note on PR #22.
This was referenced Jul 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Conventions
urllib/json; ruff/pytest aredev tooling only).
0600).docs/AGENT-FRIENDLY.md(description + CLI I/O are the contract).Mail.Read-only read path, scope ratchet for writes,verify-then-install (read-only catch-set), file-to-folder (never delete).
Verification
ruff check .andruff format --check .pass.python3 -m pytest -qpasses.