Repository navigation
ci(upstream-sync): merge a sync only after gate.yml passes on it - #36
Merged
Merged
Conversation
The smoke pinned omp v18.12.6, six releases behind. The v18.14.1 digest matches the release asset and the sha256 of the downloaded file. actions/checkout@v4 runs on Node.js 20, and every job warned about it.
…t suite The syntax step read only omp-port/*.sh, and the extension step named two test files, so a new script or extension test was never checked. The statechart suite had no CI step at all. It runs on Node 22 through the package's own test script and the fast-check pin in its package.json.
The sync job opened the PR and squash-merged it in one step, after check-port.sh alone. PRs #19 and #32 landed 3 to 4 seconds after they opened, and no gate.yml run checked either one. gate.yml now takes a workflow_call ref. upstream-sync splits into sync, gate, and merge jobs. The gate job calls gate.yml on the sync commit, and the merge job needs both earlier jobs to pass and the PR head to still match that commit. PORTING.md drops the claim that a token-opened PR starts no pull_request run.
The builtin tool probe on the v18.14.1 release asset lists wait and no hub. `omp read omp://approval-mode.md` on that binary still states the three approval facts. The 18.12.2 and 18.1.13 lines keep their versions because their probes did not run again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The sync workflow opened its PR and squash-merged it in the same step, after
check-port.shalone. PRs #19 and #32 landed 3 to 4 seconds after they opened, and nogate.ymlrun checked either one. The smoke also pinned an omp six releases old, and some scripts and suites had no CI step.What changed
gate.ymltakes aworkflow_callinputref.upstream-syncnow runs three jobs.syncbuilds, pushes, and opens the PR.gatecallsgate.ymlon the sync commit.mergeneeds both to pass and the PR head to still match the gated commit.gate.ymlsyntax-checks every tracked*.sh, runsbun test ./extensions, and adds astatechartjob on Node 22.actions/checkoutto v7.PORTING.mddescribes the new sync gate and moves two re-confirmed omp versions to 18.14.1.Scope
mainmoves while the gate runs, the merged tree is not gated.Tradeoffs
npm testand installs thefast-checkpin from itspackage.json. A second copy of the command and the version in the workflow would drift from the package.Blast Radius
Only CI changes. A clean sync now waits for the full
gate.ymlbefore it merges. A red gate leaves the PR open, and later syncs stop at the open-PR guard until someone resolves it.Verification
actionlint1.7.12 on both workflows: no errors. A copy with a wrong input name and a wrong output name fails with three errors, so the lint checks the call contract.npm install --no-package-lockandnpm testin a scratch copy of the statechart skill: 334 tests, 267 pass, 67 skip, 0 fail, 53 s.sha256sum --checkon the downloaded v18.14.1 asset: OK. With that binary onPATH,smoke-plugin.mjspassed with 60/60 skills, andtest-worktree-audit.shwithOMP_AUDIT_LIVE_REQUIRED=1passed.bash omp-port/check-port.sh: PASS.bun test ./extensions: 15 pass. The new loop parsed all 7 tracked shell scripts.workflow_callpath and themergejob. Aworkflow_dispatchofupstream-syncwith no sync PR open would run them, and on success it merges intomain.